Clarified Attribute Option already exists response

[J0rdyV]

Description (*)

Replaced the awkward phrase "Get new file name if the same is already exists" with a clearer and grammatically correct version: "Get a new file name if one already exists." This improves readability and user understanding. Same for the attribute option response.

Manual testing scenarios (*)

1. pushing an already existing attribute option to the attribute option api endpoint.

Questions or comments

First time PR to Magento. Please let me know if i need to do something else.

Contribution checklist (*)

• [x] Pull request has a meaningful description of its purpose
• [x] All commits are accompanied by meaningful commit messages
• [x] All new or changed code is covered with unit/integration tests (if applicable)
• [x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

1. [x] resolves magento/magento2#39943: Clarified Attribute Option already exists response

[m2-assistant[bot]]

Hi @J0rdyV. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment. :exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

[J0rdyV]

@magento run all tests

[engcom-Hotel]

@magento create issue

[J0rdyV]

@magento run all tests

[engcom-Bravo]

Hi @J0rdyV,

Thanks for your Contribution!!.

Could you please elaborate the steps to reproduce to reproduce and confirm the issue as per the process if possible please provide screenshots to proceed further.

Thanks.

[J0rdyV]

Hey @engcom-Bravo ,

This happens when you try to create an attribute option twice with the same value on the post endpoint.

https://adobe-commerce.redoc.ly/2.4.8-admin/tag/productsattributesattributeCodeoptions#operation/PostV1ProductsAttributesAttributeCodeOptions

[engcom-Bravo]

@magento run all tests

[engcom-Bravo]

Hi @J0rdyV,

Thanks for the collaboration & contribution!

:heavy_check_mark: QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

Try to create an attribute option twice with the same value on the post endpoint.

Before: :heavy_multiplication_x: 

After: :heavy_check_mark:

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

[J0rdyV]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[J0rdyV]

@engcom-Bravo This was a simple typo.. Do changes always take so long to be merged?

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Functional Tests B2B, Functional Tests EE

[engcom-Dash]

The B2B and EE failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes.

B2B Build 1 https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39941/92f0eb3c9b1a569b3965677c84d7979b/Functional/allure-report-b2b/index.html#categories

Build 2 https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39941/c4a4f0c88f9805da1c50b05d448f3fd7/Functional/allure-report-b2b/index.html#categories

EE Build 1 https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39941/da3c32313ce0ab219586fa11b136ec2b/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2 https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39941/93a46ed69b91927152a0317f7a93825b/Functional/allure-report-ee/index.html#categories

Hence, Moving this PR to Merge In Progress