magento2
magento2 copied to clipboard
magento/magento2#39861: Shipment email not sent when submitted from Admin Order view despite being enabled in store configuration
Description (*)
\Magento\Shipping\Controller\Adminhtml\Order\Shipment\Save::execute
if (!empty($data['send_email']) && $this->salesData->canSendNewShipmentEmail()) {
$this->shipmentSender->send($shipment);
}
without the right 'store id' checks only default config value
Related Pull Requests
Fixed Issues (if relevant)
- Fixes https://github.com/magento/magento2/issues/39861
Manual testing scenarios (*)
- Set up a multi-website configuration where the default has shipment emails disabled
- Create an order in a secondary website that has shipment emails enabled
- Go to Admin > Sales > Orders
- Open the order from the secondary store
- Click on "Ship" button
- Fill in shipment details and check "Email Copy of Shipment"
- Submit the shipment
Questions or comments
Contribution checklist (*)
- [ ] Pull request has a meaningful description of its purpose
- [ ] All commits are accompanied by meaningful commit messages
- [ ] All new or changed code is covered with unit/integration tests (if applicable)
- [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- [ ] All automated tests passed successfully (all builds are green)