magento2
magento2 copied to clipboard
Magento 2.4.8: Fixed missing screen-l styles added using .media-width mixin
Description
This PR fixes completely missing screen-l styles in Magento 2.4.8. This commit https://github.com/magento/magento2/commit/438f9782d85fe6a2694ccc01c97f2a4c2a81f5bb causes the issue
Fixed Issues
- Fixes https://github.com/magento/magento2/issues/39817
Manual testing scenarios
Open category page on large screen (>1024) and see products columns count.
| Without PR | With PR |
|---|---|
Questions or comments
While this PR fully fixes the issue, I would like to hear your thoughts on the code added in commit that caused the issue. This code was added instead of old mixin:
@media all and (max-width: (@screen__l - 1)),
print {
.media-width('max', @screen__l);
}
I believe this code should be removed? I can't find out if it's used. Can somebody from Magento confirm that this code is needed and used by magento?
Contribution checklist
- [x] Pull request has a meaningful description of its purpose
- [x] All commits are accompanied by meaningful commit messages
- [ ] All new or changed code is covered with unit/integration tests (if applicable)
- [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- [ ] All automated tests passed successfully (all builds are green)