Customer email confirmation rate limit

[Mohamed-Asar]

Description (*)

Rate limit enabled for customer confirmation link email

Fixed Issues (if relevant)

1. Fixes #39813

Manual testing scenarios (*)

1. Enable Email Confirmation required for customer signup
2. Create a customer account
3. Go to customer confirmation link page(/customer/account/confirmation)
4. Try request multiple confirmation link for the same email

Contribution checklist (*)

• [ ] Pull request has a meaningful description of its purpose
• [ ] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ ] All automated tests passed successfully (all builds are green)

[m2-assistant[bot]]

Hi @Mohamed-Asar. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment. :exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

[Mohamed-Asar]

@magento run all tests

[engcom-Hotel]

Hello @Mohamed-Asar,

Thanks for the contribution!

Please resolve the conflicts in this PR. In the meantime, I am moving this PR to the "On Hold" bucket.

Thanks

[Mohamed-Asar]

@engcom-Hotel I fixed the conflicts, please review

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @Mohamed-Asar,

Thanks for resolving the conflicts!

Since the related issue is categorised as feature request, we have sent an email to the PO for approval.

Meanwhile we are moving this PR on hold.

Thanks

[engcom-Hotel]

@magento run all tests

[Mohamed-Asar]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[Mohamed-Asar]

@engcom-Hotel Let me check and fix the failed test cases.

[Mohamed-Asar]

@magento run all tests

[Mohamed-Asar]

@magento run all tests

[Mohamed-Asar]

@engcom-Hotel i've fixed the failed tests related to these code changes, could you please let me know how can i fix semantic version checker ? do i need to change the module version ?

[engcom-Hotel]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Magento Health Index

[engcom-Hotel]

Hello @Mohamed-Asar,

Thank you for fixing the test failures. We will open an internal JIRA for the SVC failure to obtain approval. However, I still see some static tests failing and other failures that appear flaky. Please resolve the remaining static failures and let us know when this PR is ready for review.

Thank you

[Mohamed-Asar]

@magento run all tests

[Mohamed-Asar]

@magento run all tests

[Mohamed-Asar]

@magento run all tests

[Mohamed-Asar]

Hello @Mohamed-Asar,

Thank you for fixing the test failures. We will open an internal JIRA for the SVC failure to obtain approval. However, I still see some static tests failing and other failures that appear flaky. Please resolve the remaining static failures and let us know when this PR is ready for review.

Thank you

@engcom-Hotel Fixed the static test failures, please review

[engcom-Hotel]

@magento run all tests

[Mohamed-Asar]

@magento run all tests

[engcom-Bravo]

Hi @Mohamed-Asar,

Thanks for your Contribution!!.

We have tried and verified the feature but after taking PR changes bin/magento indexer:reindex && bin/magento c:f stops with below error.Please refer the screenshot.

Please let us know if we are missing anything.

Thanks.

[Mohamed-Asar]

@engcom-Bravo let me check and fix it

[Mohamed-Asar]

@engcom-Bravo I checked in my local env, but don't see any issues, it was working fine