magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Checking nullability of test properties before setting to null in integration test framework cleanup

Open stollr opened this issue 1 year ago • 2 comments

Description (*)

Previously an error occured if a non-nullable typed property was used in a test case. The error message was something like

Cannot assign null to property MyVendor\MyModule\Test\Integration\MyTest::$objectManager of type Magento\Framework\ObjectManagerInterface

Manual testing scenarios (*)

  1. Add a non-nullable typed property to an integration test (like the one in the DummyTestCase in this PR)
  2. Run the test
  3. In the test result there will occur an error message looking like the above one.

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [x] All new or changed code is covered with unit/integration tests (if applicable)
  • [x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

  1. [x] resolves magento/magento2#39245: Checking nullability of test properties before setting to null in integration test framework cleanup

stollr avatar Oct 02 '24 15:10 stollr

Hi @stollr. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment. :exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Oct 02 '24 15:10 m2-assistant[bot]

@magento create issue

engcom-Hotel avatar Oct 08 '24 11:10 engcom-Hotel