magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Fix split button in order view page

Open SerhiiMandrykin opened this issue 1 year ago • 6 comments

Description (*)

This PR adds a fix for split buttons used in layout admin-2columns-left.xml The bug was added by 6ed18327 so this is a rollback of changes. Admin Panel is not for mobile so no need to add any changes to fix issues on mobile/tablet. Here is the video of the issue:

https://github.com/user-attachments/assets/84420833-ac5e-4172-93fe-173fa445bd8a

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

  1. Create a custom split button on order view page.
  2. Go to Frontend and place an order
  3. Go to Admin Panel -> Sales -> Orders
  4. Go to the order view page.

Questions or comments

None

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

  1. [x] resolves magento/magento2#39080: Fix split button in order view page

SerhiiMandrykin avatar Aug 21 '24 10:08 SerhiiMandrykin

Hi @SerhiiMandrykin. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Aug 21 '24 10:08 m2-assistant[bot]

@magento run all tests

SerhiiMandrykin avatar Aug 21 '24 10:08 SerhiiMandrykin

@magento create issue

engcom-Hotel avatar Aug 21 '24 12:08 engcom-Hotel

@engcom-Hotel, could you please share what is the issue was fixed in ACP2E-2083? Just to make sure we're not doing any regression in this Pull Request

ihor-sviziev avatar Aug 22 '24 16:08 ihor-sviziev

Hello @ihor-sviziev,

JIRA ACP2E-2083 contains the fix for the "Login as customer" button in the admin panel when accessing it via tab/phone.

Before fix it looks something like this:

image

Thanks

engcom-Hotel avatar Aug 23 '24 09:08 engcom-Hotel

So, the scrolling has to be only horizontal, right?

ihor-sviziev avatar Aug 23 '24 10:08 ihor-sviziev

@magento run all tests

engcom-Hotel avatar Sep 13 '24 10:09 engcom-Hotel

Hello @SerhiiMandrykin,

Looks like the issue is fixed on the latest 2.4-develop branch, could you please check on your end and let us know if the issue still persist. Till then moving this to on hold.

Thank you.

engcom-November avatar Sep 17 '24 07:09 engcom-November

Hello @SerhiiMandrykin,

We have attempted to reproduce the issue in the latest 2.4-develop branch, and it appears the issue is no longer reproducible. It seems the issue has already been resolved. Please refer to the screencast below for reference:

Products-Inventory-Catalog-Magento-Admin.webm

Based on this, we will proceed to close this PR. However, we sincerely appreciate your contribution and look forward to more contributions from you in the future.

thanks

engcom-Hotel avatar Nov 26 '24 10:11 engcom-Hotel