magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Wishlist sharing form allows random code in the name fields

Open ganeddact opened this issue 1 year ago • 10 comments

Preconditions and environment

  • Magento version 2.4.6-p6, probably works on 2.4.7-p1 as well

Steps to reproduce

  1. Install a fresh Magento latest version with sample data
  2. Register as a customer and login
  3. Add a product to the wishlist
  4. Click to share the wishlist
  5. Add the following code to the wishlist share message: {{var this.getTempl%0d%0aateFilter().filter(%22ls -al%22)}}{{if this.getTempla%0d%0ateFilter().addAft%0d%0aerFilterCallback(%22SySTeM%22).filter(%22ls -al%22)}}{{/if}}

Expected result

Magento should block the sending of this type of text and not allow template injection

Actual result

An email with the code is fired out with no error raised

Additional information

It's a sister issue of https://github.com/magento/magento2/issues/38331 and https://github.com/magento/magento2/issues/39002

Release note

No response

Triage and priority

  • [X] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

ganeddact avatar Aug 08 '24 10:08 ganeddact

Hi @ganeddact. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] avatar Aug 08 '24 10:08 m2-assistant[bot]

@magento give me 2.4-develop instance

ganeddact avatar Aug 08 '24 10:08 ganeddact

Hi @ganeddact. Thank you for your request. I'm working on Magento instance for you.

Hi @ganeddact, here is your Magento Instance: https://a896b45b2fc43dee6a7d8360a5c35270.instances-prod.magento-community.engineering Admin access: https://a896b45b2fc43dee6a7d8360a5c35270.instances-prod.magento-community.engineering/admin_f160 Login: 910b7af8 Password: 0da1d1f732c6

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Aug 08 '24 10:08 m2-assistant[bot]

The Magento instance doesn't allow to send emails from either wishlist sharing or contact page, is it turned off at server level?

ganeddact avatar Aug 08 '24 10:08 ganeddact

This is what I get on our private test magento instance (on 2.4.6-p6) Screenshot 2024-08-08 at 11 52 14 and the email: Screenshot 2024-08-08 at 11 53 51

ganeddact avatar Aug 08 '24 10:08 ganeddact

Hi @ganeddact,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.kindly refer the screenshots.

Steps to reproduce

  • Register as a customer and login
  • Add a product to the wishlist
  • Click to share the wishlist
  • Add the following code to the wishlist share message: {{var this.getTempl%0d%0aateFilter().filter(%22ls -al%22)}}{{if this.getTempla%0d%0ateFilter().addAft%0d%0aerFilterCallback(%22SySTeM%22).filter(%22ls -al%22)}}{{/if}}
Screenshot 2024-08-09 at 10 50 53

There is no error raised while sharing the wishlist.

Hence Confirming the issue.

Thanks.

engcom-Bravo avatar Aug 09 '24 06:08 engcom-Bravo

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12730 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Aug 09 '24 06:08 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Aug 09 '24 06:08 m2-assistant[bot]

Hello @ganeddact ,

Adobe Commerce Engineering team started working on this issue. We will reach out to you if we need more information and you will get notified once the issue is fixed. Please leave comments for any further questions.

Thank you!

engcom-November avatar Nov 24 '25 05:11 engcom-November