magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

fix: Prevent loops in resolving final URL Rewrite

Open pmzandbergen opened this issue 8 months ago • 6 comments

Description (*)

URL rewrites with the same request and target path will create a loop in the GraphQL resolver.

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. Fixes magento/magento2#38692

Manual testing scenarios (*)

  1. Create a URL rewrite with the same request and target path
  2. Resolve the URL rewrite using GraphQL
  3. Test with and without this PR

Questions or comments

N/A

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

pmzandbergen avatar May 29 '24 09:05 pmzandbergen