magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Configurable Product video not loading/playing for "root" product when Javascript bundling is enabled

Open chazzs opened this issue 1 year ago • 12 comments

Preconditions and environment

  • Magento version = 2.4.4-p8
  • PHP 8.1.20

Seems to only affect the root configurable product and not the configured simple products. The simple products will load and play videos just fine when selections are made on the proudct page. It is the video set for the root configurable product that will not play/load.

Steps to reproduce

  1. Create configuarable product and configurations.
  2. Add video to root/master product (not the simple product configurations)
  3. Enable Javascript Bundling and clean/build static content, clean cache.
  4. Load product page (make no configuration selection)' the video does not load or play, just displays the video image.
  5. Disable javascript bundling and clean cache
  6. Load product page (make no configuration selection); the Video Functions.
  7. Enable Javascript bundling and clean cache
  8. Load product page (make no configuration selection); the video is broken again.

Expected result

I would expect the video for root configurable product to function/play regardless of bundling enabled or disabled.

Actual result

When Javascript bundling is enabled; videos assigned to the root configurable product will not load or play in the image carousel. It will simply display the video thumb/capture.

When Javascript bundling is disabled; videos assigned to the root configurable product will load and play in the image carousel.

Additional information

I suppose a workaround would be to disable bundling but that would adversly affect site load and performance.

Release note

No response

Triage and priority

  • [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [X] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

chazzs avatar May 21 '24 19:05 chazzs

Hi @chazzs. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] avatar May 21 '24 19:05 m2-assistant[bot]

@magento give me 2.4.4-p8 instance

chazzs avatar May 21 '24 19:05 chazzs

Hi @chazzs. Thank you for your request. I'm working on Magento instance for you.

Hi @chazzs, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@magento give me 2.4-develop instance

chazzs avatar May 21 '24 19:05 chazzs

Hi @chazzs. Thank you for your request. I'm working on Magento instance for you.

Hi @chazzs, here is your Magento Instance: https://0de6e03a601e1d450d2d324ce83e0a3a.instances-prod.magento-community.engineering Admin access: https://0de6e03a601e1d450d2d324ce83e0a3a.instances-prod.magento-community.engineering/admin_bf2c Login: d9a28e45 Password: 4cd332e03b2d

https://0de6e03a601e1d450d2d324ce83e0a3a.instances-prod.magento-community.engineering/chaz-kangeroo-hoodie.html

is a configurable product with a video.

chazzs avatar May 21 '24 20:05 chazzs

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar May 22 '24 02:05 m2-assistant[bot]

@magento give me 2.4-develop instance

engcom-Delta avatar May 22 '24 09:05 engcom-Delta

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Delta, here is your Magento Instance: https://0de6e03a601e1d450d2d324ce83e0a3a.instances-prod.magento-community.engineering Admin access: https://0de6e03a601e1d450d2d324ce83e0a3a.instances-prod.magento-community.engineering/admin_a8a2 Login: 126c363f Password: b494309131a7

Hi @chazzs ,

Verified the issue on 2.4-develop and we are not able to reproduce this issue.

Steps to reproduce:-

1.Create configurable product and configurations. 2.Add video to root/master product (not the simple product configurations) 3.Enable Javascript Bundling and clean/build static content, clean cache. 4.Load product page (make no configuration selection)' the video does not load or play, just displays the video image. 5.Disable javascript bundling and clean cache 6.Load product page (make no configuration selection); the Video Functions. 7.Enable Javascript bundling and clean cache 8.Load product page (make no configuration selection); the video is broken again.

Please refer the attached screenshots and let us know if we missed anything.

Create configurable product

Screenshot 2024-05-27 at 8 14 06 PM

Add video to root/master product

Screenshot 2024-05-27 at 8 17 57 PM

Enable Javascript Bundling

Screenshot 2024-05-27 at 8 20 29 PM Screenshot 2024-05-27 at 8 24 13 PM

build static content and clean cache

Screenshot 2024-05-27 at 8 24 22 PM

Go to frontend

Screenshot 2024-05-27 at 8 27 46 PM

Load product

Screenshot 2024-05-27 at 8 28 10 PM

Disable Javascript Bundling

Screenshot 2024-05-27 at 8 30 27 PM

Load product page

Screenshot 2024-05-27 at 8 31 16 PM

Enable Javascript bundling and clean cache

Screenshot 2024-05-27 at 8 34 32 PM Screenshot 2024-05-27 at 8 35 29 PM

Load product page

Screenshot 2024-05-27 at 8 35 58 PM

When we play the button , the video plays in both cases, it's not broken

engcom-Delta avatar May 27 '24 15:05 engcom-Delta

Did you make sure the server was in production deployment mode? the instance that was given to me was in development mode and when in development mode the bundling does not work. you can enable bundling but it will not bundle and serve the bundles to the front end.

i tried to access the front end you worked on to verify but it appears to be gone now. I tried to build a product with the instance provided to me when i asked for one, but it did not appear that i could access the backend (ssh) to actually enable production mode.

chazzs avatar May 29 '24 15:05 chazzs

Hi @chazzs ,

I have set to production now and verified on 2.4-develop but we are not able to reproduce this issue.

Steps to reproduce:-

1.Create configurable product. 2.Add video to root/master product (not the simple product configurations) 3.Enable Javascript Bundling and clean/build static content, clean cache. 4.Load product page (make no configuration selection)' the video does not load or play, just displays the video image. 5.Disable javascript bundling and clean cache 6.Load product page (make no configuration selection); the Video Functions. 7.Enable Javascript bundling and clean cache 8.Load product page (make no configuration selection); the video is broken again.

Please refer the attached screenshots and let us know if we missed anything.

Enable Production Mode on magento

Screenshot 2024-05-30 at 12 52 56 PM

Added video to root/master product

Screenshot 2024-05-30 at 3 11 31 PM

Enable Javascript Bundling and clean/build static content, clean cache

Screenshot 2024-05-30 at 2 46 53 PM

Load product page

Screenshot 2024-05-30 at 3 01 54 PM

Video showing and playing

Screenshot 2024-05-30 at 3 02 19 PM

Disable javascript bundling and clean cache

Screenshot 2024-05-30 at 3 03 07 PM

Load product page, Video showing and playing

Screenshot 2024-05-30 at 3 04 27 PM

Enable Javascript bundling and clean cache

Screenshot 2024-05-30 at 3 05 00 PM

Video showing and playing, not broken

https://github.com/magento/magento2/assets/51681379/e8e6fb24-58df-416b-892b-a2e4e703488c

engcom-Delta avatar May 30 '24 09:05 engcom-Delta

It seems something got fixed between 2.4.4-p8 and now. I am using 2.4.4-p8 and it definitely does not work. Naturally I have overridden the layout of the product pages, but I have made no changes to the image carousel functionality. It looks like I am hosed until I can get things up to date.

chazzs avatar May 30 '24 14:05 chazzs

Hi @chazzs ,

It is recommended that we should upgrade to the latest version of magento while working with it unless there is some conditions.By using latest version it lowers all the vulnerabilities and we get all the recent fixes.

As of now this issue is not in the latest versions of magento.

Thanks,

engcom-Delta avatar Jun 04 '24 07:06 engcom-Delta

Hello @chazzs ,

As there is no activity on this issue for a long time, we believe the issue has been resolved, hence closing this issue. Feel free to raise a new issue or reopen this if you still face it.

Thank you.

engcom-Delta avatar Jun 12 '24 20:06 engcom-Delta