magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Vault/Stored Payment Methods not selected value when changing the uncheck/check my billing address and shipping address are the same

Open vbuiendertech opened this issue 1 year ago • 14 comments

Preconditions and environment

  • Magento version 2.4.6-p5
  • Braintree Payment Method (with Stored Cards)

Steps to reproduce

  1. Add a product to the cart and redirect to the checkout/#payment page. (Step 2 on the checkout page.)
  2. Selected any payment method on the Stored Payment method
  3. Uncheck the option My billing and shipping address are the same. => Click the update with the new address.

Expected result

After unchecking/checking the checkbox, my billing and shipping address are the same, and click on the Update button. Selecting "My billing and shipping address are the same" should not de-select the selected stored credit card.

Actual result

Selecting “My billing and shipping address are the same” under the stored credit card would de-select the selected stored credit card.

Screenshot 2024-05-14 at 10 40 44 Screenshot 2024-05-14 at 10 40 54

This is my video test:

https://drive.google.com/file/d/1nq3MZpX5GKbtVaz_5g1WdyAYF0RcUL2A/view

Additional information

No response

Release note

No response

Triage and priority

  • [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [x] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

vbuiendertech avatar May 14 '24 03:05 vbuiendertech

Hi @vbuiendertech. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] avatar May 14 '24 03:05 m2-assistant[bot]

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar May 14 '24 03:05 m2-assistant[bot]

@magento give me 2.4-develop instance

engcom-Delta avatar May 15 '24 08:05 engcom-Delta

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Delta, here is your Magento Instance: https://2ff49090b319f9878babdc8527895b2a.instances-prod.magento-community.engineering Admin access: https://2ff49090b319f9878babdc8527895b2a.instances-prod.magento-community.engineering/admin_cfed Login: 49cb31cc Password: 0a55a07c226d

@magento give me 2.4.7 instance

engcom-Delta avatar May 16 '24 10:05 engcom-Delta

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Delta, here is your Magento Instance: https://80fe48559389eaa2c094b83390086698.instances-prod.magento-community.engineering Admin access: https://80fe48559389eaa2c094b83390086698.instances-prod.magento-community.engineering/admin_088d Login: 016cbbd0 Password: 19f482e3a791

Hi @vbuiendertech ,

Thanks for reporting and collaboration.

Verified the issue in magento 2.4-develop instance and the issue is not reproducible.

Preconditions:-

Braintree Payment Method (with Stored Cards)

Steps to reproduce:-

1.Add a product to the cart and redirect to the checkout/#payment page. (Step 2 on the checkout page.) 2.Selected any payment method on the Stored Payment method 3.Uncheck the option My billing and shipping address are the same. => Click the update with the new address.

After unchecking/checking the checkbox, my billing and shipping address are the same, and click on the Update button. Selecting "My billing and shipping address are the same" doesn't de-select the selected stored credit card.

https://github.com/magento/magento2/assets/51681379/f1cdcc9c-1aad-4006-a1cd-7165222e8348

engcom-Delta avatar May 17 '24 11:05 engcom-Delta

Hi @engcom-Delta

Thank you for response.

But you tested on the Magento 2.4.7 and Braintree Payment v4.6.1.

My issue existed on Magento 2.4.6-p5 ( this Magento version uses Braintree Payment v4.5.0-p1)

Can you please test this issue on Magento 2.4.6-p5 and Braintree Payment v4.5.0-p1? and provide patches to resolve this issue before we upgrade to Magento 2.4.7?

Thank you in advance!

VietBui

vbuiendertech avatar May 20 '24 04:05 vbuiendertech

Hi @engcom-Delta

I will reopen this ticket.

Please confirm with me.

My issue existed on Magento 2.4.6-p5 ( this Magento version uses Braintree Payment v4.5.0-p1)

Thank you so much.

vbuiendertech avatar May 20 '24 04:05 vbuiendertech

Hi @vbuiendertech ,

Thanks for reporting and collaboration.

Verified the issue in latest magento 2.4.7 instance and the issue is not reproducible.

Preconditions:-

Braintree Payment Method (with Stored Cards)

Steps to reproduce:-

1.Add a product to the cart and redirect to the checkout/#payment page. (Step 2 on the checkout page.) 2.Selected any payment method on the Stored Payment method 3.Uncheck the option My billing and shipping address are the same. => Click the update with the new address.

After unchecking/checking the checkbox, my billing and shipping address are the same, and click on the Update button. Selecting "My billing and shipping address are the same" doesn't de-select the selected stored credit card.

https://github.com/magento/magento2/assets/51681379/79af7807-0075-40e5-9f71-7fd0d0367ba0

engcom-Delta avatar May 20 '24 20:05 engcom-Delta

Hi @engcom-Delta,

Thanks for reporting and collaboration.

I know this issue can't be reproduced on Magento 2.4.7

But you can reproduce this issue on Magento 2.4.6-p5.

Currently, my site uses Magento 2.4.6 -p5 and still hasn't plan upgrade to Magento 2.4.7

Can you provide patches to fix this issue on the Magento 2.4.6-p5?

Thank you in advance!

vbuiendertech avatar May 21 '24 01:05 vbuiendertech

Hi @vbuiendertech ,

Thanks for reporting and collaboration.

Verified the issue in magento 2.4.6-p5 instance and the issue is reproducible.

Preconditions:-

Braintree Payment Method (with Stored Cards)

Steps to reproduce:-

1.Add a product to the cart and redirect to the checkout/#payment page. (Step 2 on the checkout page.) 2.Selected any payment method on the Stored Payment method 3.Uncheck the option My billing and shipping address are the same. => Click the update with the new address.

Selecting “My billing and shipping address are the same” under the stored credit card would de-select the selected stored credit card.

https://github.com/magento/magento2/assets/51681379/006c832a-472e-408e-a13f-3df2bdd9bf7b

We will get back to you soon for the patch required by you, meanwhile we are putting this issue on hold.

engcom-Delta avatar May 23 '24 13:05 engcom-Delta

Hi @vbuiendertech ,

Thanks for reporting and collaboration. Verified the issue in magento 2.4.6-p5 instance and the issue is reproducible. However, Issue is not replicable in latest version i.e. 2.4.7-p2. Issue must have been addressed in latest versions, we suggest you to please upgrade your version.

Preconditions:- Braintree Payment Method (with Stored Cards)

Steps to reproduce:- 1.Add a product to the cart and redirect to the checkout/#payment page. (Step 2 on the checkout page.) 2.Selected any payment method on the Stored Payment method 3.Uncheck the option My billing and shipping address are the same. => Click the update with the new address. Selecting “My billing and shipping address are the same” under the stored credit card would de-select the selected stored credit card.

https://github.com/user-attachments/assets/e2f9ba6f-087c-4aff-b5a6-87b885b1503b

Thanks.

engcom-Delta avatar Aug 22 '24 11:08 engcom-Delta

FYI The issue was fixed in the commit https://github.com/magento/magento2/commit/cfac1ff2d3ab10f083ff976c7b9f1bafb9d0cd83

randix0 avatar Apr 03 '25 10:04 randix0