magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Drop page id from result

Open thomas-kl1 opened this issue 1 year ago • 4 comments

Description (*)

Given the unit test: \Magento\Cms\Test\Unit\Model\GetUtilityPageIdentifiersTest::testExecute

Expected result is a list of identifiers. Currently, if we set the following settings from BO:

  • web/default/cms_home_page
  • web/default/cms_no_route
  • web/default/cms_no_cookies

The format saved in the config is: |<page_id>

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#38666

Manual testing scenarios (*)

  1. 2 websites (a & b) with a specific home page configured for each (e.g: home-a for global, and home-b for website b)
  2. Create a sitemap for each websites
  3. Generate the sitemap from the admin grid

Questions or comments

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

thomas-kl1 avatar Apr 26 '24 09:04 thomas-kl1