magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Category description WYSIWYG is empty on non default storeview

Open thlassche opened this issue 1 year ago • 6 comments

Preconditions and environment

  • Magento version: 2.4.7
  • Pagebuilder modules disabled

Steps to reproduce

  1. Edit category in the backend on storeview level
  2. Untick the box 'Use default value' next to the category description field WYSWYG editor
  3. Enter a description in the WYSIWYG editor
  4. Save

Expected result

Description is saved and shown in the edit form

Actual result

WYSIWYG editor is empty after load

Additional information

This is due to a change in dom-observer.js in https://github.com/magento/magento2/commit/5b931fec7dedb343a303bef40ec47c4b5f58859f

The return here now exits the loop early, which wasn't the case before, since it was inside a _ function before: https://github.com/magento/magento2/commit/5b931fec7dedb343a303bef40ec47c4b5f58859f#diff-844cfb7b272693bacaa64be3a0fd96a543cc145b478330777c39682cc15b5961R152

Patch that fixes the issue:

Index: src/vendor/magento/module-ui/view/base/web/js/lib/view/utils/dom-observer.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/view/base/web/js/lib/view/utils/dom-observer.js b/view/base/web/js/lib/view/utils/dom-observer.js
--- a/view/base/web/js/lib/view/utils/dom-observer.js	
+++ b/view/base/web/js/lib/view/utils/dom-observer.js	(date 1713248057631)
@@ -149,7 +149,7 @@
         _.each(watchers.selectors, function (listeners, selector) {
             for (let data of listeners) {
                 if (!data.ctx.contains(node) || !$(node, data.ctx).is(selector)) {
-                    break;
+                    continue;
                 }
 
                 if (data.type === 'add') {

Release note

No response

Triage and priority

  • [X] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

thlassche avatar Apr 16 '24 06:04 thlassche

Hi @thlassche. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] avatar Apr 16 '24 06:04 m2-assistant[bot]

Pull request: https://github.com/magento/magento2/pull/38623

thlassche avatar Apr 16 '24 06:04 thlassche

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Apr 16 '24 10:04 m2-assistant[bot]

Hi @thlassche,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the attached screenshots.

Steps to reproduce

  • Edit category in the backend on storeview level
  • Untick the box 'Use default value' next to the category description field WYSWYG editor
  • Enter a description in the WYSIWYG editor
  • Save
Screenshot 2024-04-17 at 09 56 03

WYSIWYG editor is empty after load.

Hence Confirming the issue.

Thanks.

engcom-Bravo avatar Apr 17 '24 05:04 engcom-Bravo

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11804 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Apr 17 '24 06:04 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Apr 17 '24 06:04 m2-assistant[bot]

Hello, has this been fixed? I'm still getting this issue with Magento ver. 2.4.7-p3.

Apparently the Commit 1933e66 has not been pushed to the 2.4.7-p3 version. Editing file to apply commit seems to resolve the issue.

ShapesGraphicStudio avatar Nov 27 '24 10:11 ShapesGraphicStudio

This critical bug is still present. Please merge ASAP.

teunovic avatar Dec 13 '24 14:12 teunovic