magento2
magento2 copied to clipboard
magento
Accessibility: WAI-ARIA roles nesting wrong in menu
Fixed Issues (if relevant)
- Fixes magento/magento2#35889
Manual testing scenarios (*)
- Open the Lighthouse and do the Accessibily analysis without this PR
- Open the Lighthouse and do the Accessibily analysis with this PR
Hi @mirianfalconi. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:
@magento give me test instance- deploy test instance based on PR changes@magento give me 2.4-develop instance- deploy vanilla Magento instance
:exclamation: Automated tests can be triggered manually with an appropriate comment:
@magento run all tests- run or re-run all required tests against the PR changes@magento run <test-build(s)>- run or re-run specific test build(s) For example:@magento run Unit Tests
<test-build(s)> is a comma-separated list of build names.
Allowed build names are:
Database CompareFunctional Tests CEFunctional Tests EEFunctional Tests B2BIntegration TestsMagento Health IndexSample Data Tests CESample Data Tests EESample Data Tests B2BStatic TestsUnit TestsWebAPI TestsSemantic Version Checker
You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.
For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.
![m2-assistant[bot] avatar](https://avatars.githubusercontent.com/in/27048?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @Franciscof-Serfe. Thank you for your request. I'm working on Magento instance for you.
![magento-deployment-service[bot] avatar](https://avatars.githubusercontent.com/in/52578?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @Franciscof-Serfe, here is your Magento Instance: https://186102f3462c95ef8679028b19122c14.instances-prod.magento-community.engineering Admin access: https://186102f3462c95ef8679028b19122c14.instances-prod.magento-community.engineering/admin_ea86 Login: 3ca5520b Password: 972f89ea79cb
Hi @mirianfalconi,
Thanks for the collaboration & contribution!
:heavy_check_mark: QA Passed
Preconditions:
- Install fresh Magento
2.4-develop
Steps to reproduce
- Open the Lighthouse and do the Accessibily analysis
Before: :heavy_multiplication_x:
After: :heavy_check_mark:
Builds are failed. Hence, moving this PR to Extended Testing.
Thanks.
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests, WebAPI Tests
The consistent Functional B2B Tests failure is known issue and Jira has been raised for the same. Other failures are inconsistent and flaky. They neither part of PR nor failing because of the PR changes.
Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38617/303e929bf9415c637363a3102324ffc8/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d
Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38617/4979a069a59cfa0051c3748ef715e0fc/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d
Known Issue: StorefrontProductNoLongerVisibleInWishlistOnceUserUnassignedFromCompanyTest ACQE-8287
Hence moving this PR in Merge In Progress.
The PR was giving failures on copyright in mainline PR, hence moving it to Extended Testing.
Failed to run the builds. Please try to re-run them later.
![magento-automated-testing[bot] avatar](https://avatars.githubusercontent.com/in/43625?v=4 "Published by a pub.dev verified publisher"){kind=small}