Database tables with primary column having signed instead of unsigned definition which is loss of usable values

[kanevbg]

Preconditions and environment

• Magento develop branch

Steps to reproduce

There is nothing to reproduce, it's a theoretical, architectural problem.

Expected result

Not applicable.

Actual result

Not applicable.

Additional information

Table catalog_product_entity_text has value_id primary column defined as signed int. However the system never stores zero or negative ID in that table. .

This means we have 50% usable values of what the underlining database storage may store in practice for the data produced by the application. I have not found a single reason for that column being signed instead of unsigned. Please checkout.

This is applicable to the following tables:

• catalog_product_entity_datetime
• catalog_product_entity_decimal
• catalog_product_entity_int
• catalog_product_entity_text
• catalog_product_entity_varchar
• catalog_product_entity_gallery
• catalog_category_entity_decimal
• catalog_category_entity_int
• catalog_category_entity_text
• catalog_category_entity_varchar
• catalog_product_entity_tier_price
• customer_address_entity_decimal
• customer_address_entity_int
• customer_address_entity_text
• customer_address_entity_varchar
• customer_entity_datetime
• customer_entity_decimal
• customer_entity_int
• customer_entity_text
• customer_entity_varchar
• eav_entity_datetime
• eav_entity_decimal
• eav_entity_int
• eav_entity_text
• eav_entity_varchar
• weee_tax

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @kanevbg. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[faizanps]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @faizanps. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @faizanps, here is your Magento Instance: https://0e41f955810ef54252bf938113d242f0.instances-prod.magento-community.engineering Admin access: https://0e41f955810ef54252bf938113d242f0.instances-prod.magento-community.engineering/admin_7857 Login: cfa74781 Password: 3060e70b5a2a

[kanevbg]

@Bashev адаш така е нали 😄

[faizanps]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @faizanps. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @faizanps, here is your Magento Instance: https://0e41f955810ef54252bf938113d242f0.instances-prod.magento-community.engineering Admin access: https://0e41f955810ef54252bf938113d242f0.instances-prod.magento-community.engineering/admin_425c Login: 016dfea5 Password: 2e3132a39f56

[m2-assistant[bot]]

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Dash]

Hi @kanevbg

Thanks for reporting and collaboration.

Verified the issue in magento 2.4 dev instance. The issue is reproducable.

Database tables with primary column having signed instead of unsigned definition. Hence, confirming the issue.

Please refer the attached screenshots.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11758 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[kanevbg]

@engcom-Dash Please let me know if additional assistance or information may be helpful from my side.

[KrasnoshchokBohdan]

@magento I am working on this