magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Exception #0 (ReflectionException): Class "***********************" does not exist. Wrong logic.

Open Genaker opened this issue 1 year ago • 5 comments

Preconditions and environment

Magento 2 Core all versions have a core issue. When the source model of the EAV class from the Database does not exist magento throws

ReflectionException

Exception #0 (ReflectionException): Class "**\Model\Config\Source***\Options" does not exist

/var/www/html/magento/vendor/magento/framework/Code/Reader/ClassReader.php

 public function getConstructor($className)
    {
        $class = new ReflectionClass($className); <-- Exception happens here 

however, it has logic to tell you exactly what attribute Model is missing

/var/www/html/magento/vendor/magento/module-eav/Model/Entity/Attribute/AbstractAttribute.php

public function getSource()
    {
        if (empty($this->_source)) {
            if (!$this->getSourceModel()) {
                $this->_source = $this->_getDefaultSourceModel();
            } else {
                $this->_source = $this->getSourceModel();
            }
        
            if (!$source) {
                throw new LocalizedException(
                    __(
                        'Source model "%1" not found for attribute "%2"',
                        $this->getSourceModel(),
                        $this->getAttributeCode()
                    )
                );
            }

but this logic never happens because it is an Exception(ReflectionException) not a bool value

you need to add this code and check exception

public function getSource() { if (empty($this->_source)) { if (!$this->getSourceModel()) { $this->_source = $this->_getDefaultSourceModel(); } else { $this->_source = $this->getSourceModel(); } try { $source = $this->_universalFactory->create($this->_source); } catch (\ReflectionException $e) { $source = false; } if (!$source) { throw new LocalizedException( __( 'Source model "%1" not found for attribute "%2"', $this->getSourceModel(), $this->getAttributeCode() ) ); }

then an exception will be self-explained:

Exception #0 (Magento\Framework\Exception\LocalizedException): Source model "*****\Model\Config\Source*\Options" not found for attribute "some_attribute"

Please fix it ASAP.

Related issue: https://github.com/magento/magento2/issues/30278

Steps to reproduce

see this ticket:

https://github.com/magento/magento2/issues/30278

Expected result

Normal Exception explanation

Exception #0 (Magento\Framework\Exception\LocalizedException): Source model "*****\Model\Config\Source*\Options" not found for attribute "some_attribute"

Actual result

Exception #0 (ReflectionException): Class "***********************" does not exist.

Additional information

No response

Release note

No response

Triage and priority

  • [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Genaker avatar Feb 28 '24 21:02 Genaker

Hi @Genaker. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] avatar Feb 28 '24 21:02 m2-assistant[bot]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Feb 29 '24 07:02 m2-assistant[bot]

Hello @Genaker,

Thank you for the report and collaboration!

Verified this issue on 2.4-develop. When the source model is missing from a custom product attribute, we are seeing the below reflection exception Class "Vendor\Module\Model\Config\Source\Options" does not exist. But there is already a LocalizedException present for such case, but this logic is not being triggered, as the $source variable is always true in \Magento\Eav\Model\Entity\Attribute\AbstractAttribute::getSource.

Please take a look at the screenshot below: We are getting the below error image

Instead, we should have received something like this. image

Hence Confirming the issue.

Please find the custom module used to reproduce the issue. AttVendor.zip

Thank you.

engcom-November avatar Feb 29 '24 08:02 engcom-November

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11469 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Feb 29 '24 08:02 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Feb 29 '24 08:02 m2-assistant[bot]