magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] Update Filter.php to allow {{block template="Magento_Module::path/to/template.phtml"}} and setting \Magento\Framework\View\Element\Template as default class

Open m2-assistant[bot] opened this issue 1 year ago • 2 comments

This issue is automatically created based on existing pull request: magento/magento2#38469: Update Filter.php to allow {{block template="Magento_Module::path/to/template.phtml"}} and setting \Magento\Framework\View\Element\Template as default class


Description (*)

Besides: {{block id="static_cms_block" }} {{block id="1" }} {{block class='\Magento\Theme\Block\Html\Footer' name='test.block' template='Magento_Theme::html/footer.phtml'}}

It also allows: {{block template='Magento_Module::html/footer.phtml'}} setting as default block: \Magento\Framework\View\Element\Template

like layout.xml is doing: https://developer.adobe.com/commerce/frontend-core/guide/layouts/xml-instructions/#block

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar Feb 27 '24 11:02 m2-assistant[bot]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Feb 27 '24 11:02 m2-assistant[bot]

Hello @JDavidVR,

Thank you for collaboration and contribution!

As you are adding the \Magento\Framework\View\Element\Template class as default, so as not to include the class everytime in cms_pages & cms_blocks, this can be considered as feature request. Hence marking this issue as same.

Thank you.

engcom-November avatar Feb 28 '24 10:02 engcom-November