magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

page layout xml of pagebuilder override the layout set by theme

Open antoniocarboni opened this issue 11 months ago • 5 comments

Preconditions and environment

Magento 2.4.6-p3 with Page Builder active

Steps to reproduce

  • Create a custom theme
  • Create a catalog_category_view.xml file in the app/design/frontend/<Vendor>/<Custom_Theme>/Magento_Catalog/layout directory
  • Add the following content to the file
<?xml version="1.0"?>
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" layout="1column" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd"/>
  • Add a Category description with pagebuilder
  • Clean the cache
  • Go to the frontend and open e.g. a category

Expected result

Change the default page layout from 2columns-left to 1column.

Actual result

The page layout of the category still remains 2 columns left

Additional information

Behavior and possible fix

The Magento_PageBuilder module sets several additional layouts to Magento in the page_layout/ folder The problem is that in addition to the layout it also sets a fixed layout to the category page with the catalog_category_view.xml file.

In my opinion this declaration is redundant or, perhaps, it is an error, because the layout declaration is already present on the catalog_category_view.xml of the Magento_Catalog module.

To resolve this issue simply remove layout="2columns-left" in the catalog_category_view file of Magento_PageBuilder as it would seem useless.

UPDATE: The issue is the same reported on this closed Issue

Release note

No response

Triage and priority

  • [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [X] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

antoniocarboni avatar Feb 26 '24 21:02 antoniocarboni

Hi @antoniocarboni. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] avatar Feb 26 '24 21:02 m2-assistant[bot]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Feb 27 '24 09:02 m2-assistant[bot]

Hello @antoniocarboni,

Thank you for the report and collaboration!

Verified this issue on 2.4-develop. With PageBuilder enabled and given configuration added in catalog_category_view.xml file in the app/design/frontend//<Custom_Theme>/Magento_Catalog/layout directory, we were able to reproduce the issue.

Please take a look at the screenshot below: When PageBuilder is enabled the layout configuration in custom theme is ignored, and default layout is applied image

If we disable the PageBuilder, the layout in custom theme is applied image

Hence confirming this issue.

Thank you.

engcom-November avatar Feb 27 '24 10:02 engcom-November

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11429 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Feb 27 '24 10:02 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Feb 27 '24 10:02 m2-assistant[bot]