magento2
magento2 copied to clipboard
Update Filter.php to allow {{block template="Magento_Module::path/to/template.phtml"}} and setting \Magento\Framework\View\Element\Template as default class
Description (*)
Besides: {{block id="static_cms_block" }} {{block id="1" }} {{block class='\Magento\Theme\Block\Html\Footer' name='test.block' template='Magento_Theme::html/footer.phtml'}}
It also allows: {{block template='Magento_Module::html/footer.phtml'}} setting as default block: \Magento\Framework\View\Element\Template
like layout.xml is doing: https://developer.adobe.com/commerce/frontend-core/guide/layouts/xml-instructions/#block
Contribution checklist (*)
- [ ] Pull request has a meaningful description of its purpose
- [ ] All commits are accompanied by meaningful commit messages
- [ ] All new or changed code is covered with unit/integration tests (if applicable)
- [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- [ ] All automated tests passed successfully (all builds are green)
Resolved issues:
- [x] resolves magento/magento2#38477: Update Filter.php to allow {{block template="Magento_Module::path/to/template.phtml"}} and setting \Magento\Framework\View\Element\Template as default class
Hi @JDavidVR. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:
-
@magento give me test instance
- deploy test instance based on PR changes -
@magento give me 2.4-develop instance
- deploy vanilla Magento instance
:exclamation: Automated tests can be triggered manually with an appropriate comment:
-
@magento run all tests
- run or re-run all required tests against the PR changes -
@magento run <test-build(s)>
- run or re-run specific test build(s) For example:@magento run Unit Tests
<test-build(s)>
is a comma-separated list of build names.
Allowed build names are:
-
Database Compare
-
Functional Tests CE
-
Functional Tests EE
-
Functional Tests B2B
-
Integration Tests
-
Magento Health Index
-
Sample Data Tests CE
-
Sample Data Tests EE
-
Sample Data Tests B2B
-
Static Tests
-
Unit Tests
-
WebAPI Tests
-
Semantic Version Checker
You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.
For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.
can you describe more about the reason of this update ? and also add some test case for coverage your changes
Hello @JDavidVR Thank you for your contribution. Could you please sign Adobe CLA? Thank you in advance.
@andrewbess I've already signed the Adobe CLA
Not sure why it is not updated
@mrtuvn this change allows to call templates files in cms_pages & cms_blocks
For ex. {{block template='Magento_Module::template/file.phtml'}}
instead of {{block class= ' \Magento\Framework\View\Element\Template' template='Magento_Module::template/file.phtml'}}
this change is inspired on how layout.xml is working:
@magento run all tests
@magento create issue