magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Found duplicate products in the REST API with pagination.

Open Darshit190 opened this issue 1 year ago • 8 comments

Preconditions and environment

  • Magento version: 2.4.6-p4

Steps to reproduce

  1. Create a product attribute: attribute label "Is Featured", attribute code "is_featured" and type is Yes/No and sortable.
  2. Go to Attribute Sets and assign the "Is Featured" product attribute to the "Bag" attribute set.
  3. Open the product. SKU: 24-MB03
  4. Enable the "Is Featured" product attribute and save it.
  5. In the product search criteria, use the API method "GET" and add this URL, and run it for page 1.  https://example.com/rest/V1/products?searchCriteria[currentPage]=1&searchCriteria[pageSize]=9&searchCriteria[filter_groups][0][filters][0][field]=category_id&searchCriteria[filter_groups][0][filters][0][value]=3&searchCriteria[filter_groups][0][filters][0][condition_type]=eq&searchCriteria[filter_groups][1][filters][0][field]=visibility&searchCriteria[filter_groups][1][filters][0][value]=4&searchCriteria[filter_groups][1][filters][0][condition_type]=eq&searchCriteria[sortOrders][0][field]=is_featured&searchCriteria[sortOrders][0][direction]=desc&fields=items[id]
  6. In the product search criteria, use the API method "GET" and add this URL, and run it for page 4. (In other pages as well) https://example.com/rest/V1/products?searchCriteria[currentPage]=4&searchCriteria[pageSize]=9&searchCriteria[filter_groups][0][filters][0][field]=category_id&searchCriteria[filter_groups][0][filters][0][value]=3&searchCriteria[filter_groups][0][filters][0][condition_type]=eq&searchCriteria[filter_groups][1][filters][0][field]=visibility&searchCriteria[filter_groups][1][filters][0][value]=4&searchCriteria[filter_groups][1][filters][0][condition_type]=eq&searchCriteria[sortOrders][0][field]=is_featured&searchCriteria[sortOrders][0][direction]=desc&fields=items[id]

Expected result

In the API response output, if I set the sort order of the boolean product attribute, it should show unique products on every page.

Actual result

On page number one: ID 3 which we have enabled the "is_featured" product attribute So It's coming first. { "items": [ { "id": 3 }, { "id": 1 }, { "id": 2 }, { "id": 4 }, { "id": 5 }, { "id": 6 }, { "id": 7 }, { "id": 8 }, { "id": 9 } ] }

On page number four: I have found the duplicates products { "items": [ { "id": 9 }, { "id": 8 }, { "id": 7 }, { "id": 6 }, { "id": 5 }, { "id": 4 }, { "id": 2 } ] }

Additional information

No response

Release note

No response

Triage and priority

  • [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Darshit190 avatar Feb 22 '24 11:02 Darshit190

Hi @Darshit190. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] avatar Feb 22 '24 11:02 m2-assistant[bot]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Feb 22 '24 11:02 m2-assistant[bot]

@magento give me 2.4-develop instance

engcom-Bravo avatar Feb 23 '24 06:02 engcom-Bravo

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Bravo, here is your Magento Instance: https://9f003487b8634e546db6050c4b708e9f.instances-prod.magento-community.engineering Admin access: https://9f003487b8634e546db6050c4b708e9f.instances-prod.magento-community.engineering/admin_5169 Login: 46410707 Password: 79cc8272afbf

Hi @Darshit190,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Screenshot from 2024-02-23 12-16-24

Screenshot from 2024-02-23 12-17-48

We have found Duplicate Products.

Hence Confirming the issue.

Thanks.

engcom-Bravo avatar Feb 23 '24 06:02 engcom-Bravo

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11404 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Feb 23 '24 06:02 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Feb 23 '24 06:02 m2-assistant[bot]

@engcom-Bravo Are there any solutions to address this issue?

Darshit190 avatar Apr 03 '24 06:04 Darshit190