magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] Fix hard-coded scope store in codebase order model

Open m2-assistant[bot] opened this issue 1 year ago • 6 comments

This issue is automatically created based on existing pull request: magento/magento2#31986: Fix hard-coded scope store in codebase order model


Description (*)

Fix hard-coded store value used in code base

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

CC: @ihor-sviziev this one can be merge as quick as possible. Should not break any thing with this change

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar Feb 05 '24 14:02 m2-assistant[bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot avatar Feb 06 '24 16:02 github-jira-sync-bot

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-10981 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Feb 06 '24 16:02 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Feb 06 '24 16:02 m2-assistant[bot]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Apr 01 '24 07:04 m2-assistant[bot]

Hello @mrtuvn,

Thank you for the report and collaboration!

In the below method store is hardcoded. https://github.com/magento/magento2/blob/488c103401f7b04bfea0a339d25107ada11bd2da/app/code/Magento/Sales/Model/Order.php#L2147 Hence issue can be confirmed.

Thank you.

engcom-November avatar Apr 01 '24 07:04 engcom-November

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-10981

github-jira-sync-bot avatar Apr 01 '24 07:04 github-jira-sync-bot