Changed "active" to "enabled" in bin/magento maintenance:status command

[YevhenZvieriev]

Description (*)

I noticed that for changing maintenance mode using the commands bin/magento maintenance:enable and bin/magento maintenance:disable. But when executing the command bin/magento maintenance:status, I got Status: maintenance mode is active.

Changes Made

This Pull Request updates the output message of the bin/magento maintenance:status command. The status message has been modified for better clarity, changing from active to enabled and from not active to disabled for a more accurate representation of the maintenance mode status.

Before :

After :

Contribution checklist (*)

• [ ] Pull request has a meaningful description of its purpose
• [ ] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

1. [x] resolves magento/magento2#38486: Changed "active" to "enabled" in bin/magento maintenance:status command

[m2-assistant[bot]]

Hi @YevhenZvieriev. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

[YevhenZvieriev]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[hostep]

I'm not a fan of this, there is nothing wrong with 'active' or 'not active' in my opinion. But that's just my opinion.

Also, if we do go ahead with this, then change it in correct English and call it 'enabled' and 'not enabled' (or 'disabled') please.

[YevhenZvieriev]

Hi, @hostep!

Thank you for your feedback. I value your viewpoint and will take into account your recommendation about using 'enabled' and 'disabled' instead.

I'll update the pull request after making the required changes.

[YevhenZvieriev]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[YevhenZvieriev]

@magento run all tests

[YevhenZvieriev]

Hello @andrewbess

I've addressed the unit test failures, and the code now passes all unit tests successfully. Please review the updated version of the PR at your earliest convenience.

[andrewbess]

@magento run WebAPI Tests, Functional Tests CE, Functional Tests EE, Functional Tests B2B

[andrewbess]

@magento run WebAPI Tests, Functional Tests EE, Functional Tests B2B

[andrewbess]

@magento run WebAPI Tests, Functional Tests B2B

[andrewbess]

The WebAPI test failures look like flaky

• https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38410/ec6b8ab8d72d852d3d3be902b88971dd/WebApi/console-error-logs.html
• https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38410/d475a22075197f938e835653443d7032/WebApi/console-error-logs.html
• https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38410/794855ce474c81e2b7ec9d9e53491731/WebApi/console-error-logs.html

[engcom-Delta]

@magento create issue

[engcom-Delta]

:heavy_check_mark: QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Manual testing scenario:

1. bin/magento maintenance:enable
2. bin/magento maintenance:status
3. bin/magento maintenance:disable
4. bin/magento maintenance:status

Before: :heavy_multiplication_x: 

After: :heavy_check_mark:  

Builds are failed. Hence, moving this PR to Extended Testing.

[engcom-Echo]

@magento run all tests

[engcom-Echo]

@magento run Functional Tests CE,Functional Tests B2B

[engcom-Echo]

@magento run Functional Tests CE,Functional Tests B2B

[engcom-Echo]

Functional Tests B2B failure are different on last two run on same commit. Run1

Run2

Hence moving it to merge in progress.

[engcom-Charlie]

It seems that bot moved this PR to testing hence moving back to Merge in Progress.