magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Pagebuilder Minimum Height acting as both Minimum and Maximum

Open ZandaBear opened this issue 1 year ago • 15 comments

Preconditions and environment

  • Magento version 2.4.6-p3

Steps to reproduce

  1. Go to pagebuilder in adminhtml.
  2. Add row.
  3. Add image to element as a row background, as a banner background, or as a slider slide. Make it 200x200px for this example.
  4. Set minimum height on row or element (either one) to any static value, 100px for this example.
  5. Save page and go to view changes on front end.

Expected result

Said row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 100px

Actual result

Row or element is locked to 100px height. Image will be cropped, or scale reduced to fit within the so-called "minimum" height.

Additional information

Current workaround is to add a text box and, using the built in WYSIWYG, add an image. This allows admin to set both the height and width to scale however desired, but loses the functionality of the other elements available.

Release note

No response

Triage and priority

  • [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [X] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

ZandaBear avatar Dec 22 '23 07:12 ZandaBear

Hi @ZandaBear. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] avatar Dec 22 '23 07:12 m2-assistant[bot]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Dec 24 '23 10:12 m2-assistant[bot]

Hi @ZandaBear,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

  • Go to pagebuilder in adminhtml.
  • Add row.
  • Add element such as image, banner, slider, etc. Make it 400x400px for this example.
  • Set minimum height on row or element (either one) to any static value, 200px for this example.
  • Save page and go to view changes on front end.

New

Screenshot from 2023-12-26 11-58-14

row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 200px

Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

engcom-Bravo avatar Dec 26 '23 08:12 engcom-Bravo

Hey @engcom-Bravo,

Correction, it appears "Media -> Image" is the only one functioning correctly. Updated initial report to match. github 100px lock

As you can see pictured, with "Banner" all three modes, in order from top to bottom of Cover, Contain, Auto are incorrectly locking the height at 100px.

So, the issue appears to be encountered when doing the following... -> Image is set as Background of row (not using Media->Image) -> Image is set as Banner background. -> Image is set as a Slider Image (not background).

A similar, but different issue encounter is that the image will always look like the top-most "cover" instance in the screenshot when... -> Image is set as Slider background (NOT as a slide).

ZandaBear avatar Dec 29 '23 05:12 ZandaBear

@magento give me 2.4-develop instance

engcom-Bravo avatar Jan 03 '24 07:01 engcom-Bravo

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Bravo, here is your Magento Instance: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering Admin access: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering/admin_da4c Login: c3c96138 Password: 376a1edbb7c8

Hi @ZandaBear,

Thanks for your update.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

  • Go to pagebuilder in adminhtml.
  • Add row.
  • Add image to element as a row background, as a banner background, or as a slider slide. Make it 200x200px for this example.
  • Set minimum height on row or element (either one) to any static value, 100px for this example.
  • Save page and go to view changes on front end.

Screenshot from 2024-01-03 13-08-49

row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 100px.

Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

engcom-Bravo avatar Jan 03 '24 11:01 engcom-Bravo

@magento give me 2.4-develop instance

ZandaBear avatar Jan 04 '24 01:01 ZandaBear

Hi @ZandaBear. Thank you for your request. I'm working on Magento instance for you.

Hi @ZandaBear, here is your Magento Instance: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering Admin access: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering/admin_3642 Login: 6228b27c Password: f3bc4ebf81a7

@engcom-Bravo If you are setting the row to 100px then of course you must verify that the element's minimum height is not set to a greater value. For example, by default Magento sets banners to have a minimum height of 300px.

See screenshot for proof of the behavior I described in the initial post from the developer instance. For the screenshot, Row minimum height was set to 100px. Banner minimum height was cleared. Verified same behavior when the Row minimum height is cleared and Banner minimum is set to 100px.

Magento Issue Proof

As you can see, page-builder is not scaling banners or sliders in accordance with a minimum of 100px for the element. It is stretching or cropping the image used to a set height of 100px. The headers describe what each element is using. Only the top one is the correct size for the image of 200x200px.

ZandaBear avatar Jan 04 '24 02:01 ZandaBear

Hi @ZandaBear,

Thanks for your update.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

  • Go to pagebuilder in adminhtml.
  • Add row.
  • Add image to element as a row background, as a banner background, or as a slider slide. Make it 200x200px for this example.
  • Set minimum height on row or element (either one) to any static value, 100px for this example.
  • Save page and go to view changes on front end.

New (1)

page-builder is not scaling banners or sliders in accordance with a minimum of 100px for the element.Only the top one is the correct size for the image

Hence Confirming the issue.

Thanks.

engcom-Bravo avatar Jan 08 '24 06:01 engcom-Bravo

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-10789 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Jan 08 '24 06:01 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Jan 08 '24 06:01 m2-assistant[bot]