magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Varnish configuration does not exclude all marketing parameters

Open dverkade opened this issue 1 year ago • 5 comments

Preconditions and environment

  • Magento version: 2.4.6-p3

Steps to reproduce

Export the varnish configuration in the Magento admin and search for the part in the generated VCL file to determine that not all marketing parameters are excluded.

Expected result

All marketing parameters are excluded

Actual result

Common marketing parameters are not excluded for instance:

  • gad_source (https://support.google.com/google-ads/answer/13327296?hl=en )
  • srsltid (https://support.google.com/analytics/answer/11479699?hl=en )
  • msclkid (https://help.ads.microsoft.com/apex/index/3/en/60000 )

Additional information

No response

Release note

No response

Triage and priority

  • [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

dverkade avatar Dec 19 '23 10:12 dverkade

Hi @dverkade. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] avatar Dec 19 '23 10:12 m2-assistant[bot]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Dec 21 '23 12:12 m2-assistant[bot]

Hello @dverkade,

Thank you for the report and collaboration!

We were able to verify this on 2.4-develop. Exported the varnish configuration from the admin panel. it can be seen that gad_source, srsltid , msclkid are missing from the excluded list of marketing parameters. Please take a look at the screenshot: image

Hence confirming the issue.

Thank you.

engcom-November avatar Dec 21 '23 12:12 engcom-November

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-10738 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Dec 21 '23 12:12 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Dec 21 '23 12:12 m2-assistant[bot]