Fixed: Validation issue

[aasim110]

Description (*)

Resolved Validation issue on Checkbox fields bundle products

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#38229

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

• [x] Pull request has a meaningful description of its purpose
• [x] All commits are accompanied by meaningful commit messages
• [x] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ ] All automated tests passed successfully (all builds are green)

[m2-assistant[bot]]

Hi @aasim110. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

[aasim110]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[aasim110]

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[rogyar]

Hi @aasim110. Thanks a lot for your effort!

Could you please merge the latest changes from the 2.4-develop branch to your own? Also, please check the failing functional tests. It looks like some assertions related to the bundle products in the shopping cart are failing at the moment.

Thank you!

[aasim110]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[aasim110]

@rogyar seems like failed test not related to this commit, kindly check in detail

[engcom-Hotel]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run Functional Tests EE,Functional Tests CE,Functional Tests B2B

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[aasim110]

@magento run WebAPI Tests, Integration Tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[aasim110]

@engcom-Hotel WebAPI Tests and Integration Tests succeed and functional tests are not related to the commit.

[engcom-Echo]

@aasim110 functional failure seems to be related to PR only. Please check below test at your end once all are related to bundle product.

1. StorefrontEditBundleProductTest
2. StorefrontBundlePlaceOrderWithMultipleOptionsSuccessTest
3. StorefrontAssertFixedCartDiscountAmountForBundleProductTest
4. StorefrontAddBundleOptionsToCartTest

here is the build report

[rogyar]

Hi @aasim110. As it was mentioned, the failing tests most likely related to the changes. For example, let's check the StorefrontAddBundleOptionsToCartTest. As you can see from the report the system expects the displayed subtotal of the bundle product as 1,968.00. After your change, the displayed subtotal is 492. That's the reason why the tests are failing. A similar case is with other functional tests mentioned above.

[rogyar]

Also, I see your point that the dependence between your chances and the cart page is not obvious, but there's a dependency. If some option wasn't checked on the product detail page, for example, it affects the subtotal in the cart of the added bundle. So, most likely, after your change, the added product is different (in terms of options).

You may think in the same way to resolve issues with other tests.

Hope it's helpful.

[engcom-Echo]

@aasim110 we are moving On Hold this PR for now as PR need attention as per above comment

[engcom-Echo]

@aasim110 As the PR changes are causing build failure due to PR changes. Hence we are closing for now. Once you are ready to proceed please feel free to reopen the PR.