magento/magento2#37812: Fixed creating submenu if containing more tha…

[hutychivan]

Description (*)

If the first submenu contains more than 12 items, the column alignment is incorrect, and this prevents access to items below.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#37812

Manual testing scenarios (*)

1. Fill the first submenu's first column with more than 12 items. For example, the Content submenu.

<add id="Magento_Cms::test1" title="Test 1"
             translate="title" module="Magento_Cms" sortOrder="100"
             action="test/test/test"
             parent="Magento_Backend::content_elements" resource="Magento_Cms::page"/>
        <add id="Magento_Cms::test2" title="Test 2"
             translate="title" module="Magento_Cms" sortOrder="100"
             action="test/test/test"
             parent="Magento_Backend::content_elements" resource="Magento_Cms::page"/>
        <add id="Magento_Cms::test3" title="Test 3"
             translate="title" module="Magento_Cms" sortOrder="100"
             action="test/test/test"
             parent="Magento_Backend::content_elements" resource="Magento_Cms::page"/>
        <add id="Magento_Cms::test4" title="Test 4"
             translate="title" module="Magento_Cms" sortOrder="100"
             action="test/test/test"
             parent="Magento_Backend::content_elements" resource="Magento_Cms::page"/>
        <add id="Magento_Cms::test5" title="Test 5"
             translate="title" module="Magento_Cms" sortOrder="100"
             action="test/test/test"
             parent="Magento_Backend::content_elements" resource="Magento_Cms::page"/>
        <add id="Magento_Cms::test6" title="Test 6"
             translate="title" module="Magento_Cms" sortOrder="100"
             action="test/test/test"
             parent="Magento_Backend::content_elements" resource="Magento_Cms::page"/>
        <add id="Magento_Cms::test7" title="Test 7"
             translate="title" module="Magento_Cms" sortOrder="100"
             action="test/test/test"
             parent="Magento_Backend::content_elements" resource="Magento_Cms::page"/>
        <add id="Magento_Cms::test8" title="Test 8"
             translate="title" module="Magento_Cms" sortOrder="100"
             action="test/test/test"
             parent="Magento_Backend::content_elements" resource="Magento_Cms::page"/>
        <add id="Magento_Cms::test9" title="Test 9"
             translate="title" module="Magento_Cms" sortOrder="100"
             action="test/test/test"
             parent="Magento_Backend::content_elements" resource="Magento_Cms::page"/>

2. Lost access to the Design column in this example.

Questions or comments

After the fixes, it looks like this.

Contribution checklist (*)

• [x] Pull request has a meaningful description of its purpose
• [x] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ ] All automated tests passed successfully (all builds are green)

[m2-assistant[bot]]

Hi @hutychivan. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

[hutychivan]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

Hello @hutychivan,

Have you got chance to check this review comment https://github.com/magento/magento2/pull/38078#pullrequestreview-1737263911?

[engcom-Echo]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run Functional Tests EE,Functional Tests CE,Functional Tests B2B,Static Tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run Functional Tests CE

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run Unit Tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run Functional Tests CE,Functional Tests B2B

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

Static Tests failure is not related to this PR and its known failures and Functional Tests B2B build are green. Functional Tests CE failure are different on last two run. Run1

Run2

Moving it to Pending Review

[engcom-Echo]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

:heavy_check_mark: QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Manual testing scenario:

1. We have follow steps from comment

Before: :heavy_multiplication_x: 

After: :heavy_check_mark:  

Moving it to Extended Testing as there are build failures.

[engcom-Echo]

@magento run Functional Tests CE

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.