magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Revert Taiwan name in en_US.csv

Open MTheProgrammer opened this issue 1 year ago • 3 comments

Both governments of Taiwan (ROC) and PRC claim to be the legitimate government of all China's de jure.

Following Wikipedia: Taiwan, officially the Republic of China (ROC), is a country in East Asia.

https://en.wikipedia.org/wiki/Taiwan

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Go to Stores -> Configuration -> General -> General -> Country Options
  2. Preview any input field with country names (e.g. Allow Countries)

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

MTheProgrammer avatar Jul 11 '23 15:07 MTheProgrammer

Hi @MTheProgrammer. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Jul 11 '23 15:07 m2-assistant[bot]

@magento run all tests

MTheProgrammer avatar Jul 11 '23 15:07 MTheProgrammer

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.