magento2
magento2 copied to clipboard
magento
UPS API Change Request
Description
My client has informed me that starting from June 5, 2023, UPS no longer issues new access keys. UPS is going to change to use Oauth 2.0.
I think the magento/module-ups module should be updated to meet the requirement. It needed to be done before June 5, 2023. This is the API document https://developer.ups.com/api/reference#operation/GenerateToken.
Expected behavior
The magento/module-ups supports using the OAuth security model from UPS.
Benefits
It will help new users planning to use the UPS shipping method connect to the UPS API after June 5, 2023.
Additional information
No response
Release note
No response
Hi @ntmhung. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
-
@magento give me 2.4-develop instance- upcoming 2.4.x release - For more details, review the Magento Contributor Assistant documentation.
- Add a comment to assign the issue:
@magento I am working on this - To learn more about issue processing workflow, refer to the Code Contributions.
Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
![m2-assistant[bot] avatar](https://avatars.githubusercontent.com/in/27048?v=4 "Published by a pub.dev verified publisher"){kind=small}
HI, Please provide patch to us so we continue to use UPS as shipping method
This is a major S0 issue that Adobe will need to address in the immediate future.
The immediate impact is that starting this coming Monday, June 5 2023, merchants will no longer be able to add UPS rates to Magento. UPS will no longer generate any XML API keys, which Magento requires.
The long-term impact is that as of June 2024, every merchant that uses Magento's native UPS rate connector will no longer get rates from UPS. This has a high probability of breaking checkout, as most US merchants do not offer multiple parcel shipment providers.
Until this is resolved in Magento core, Merchants have the option of switching to a third party provider for their UPS rates, but that involves additional costs and setup. That's not an acceptable solution in the broad picture. See eg. https://twitter.com/saas_boss/status/1664354635346243585
Hello @rhoerr,
Adobe team is working on a solution for new 2.4.6 customers. All the current 2.4.4, 2.4.5 and 2.4.6 customers who are currently using the XML API gateway to get shipping rates from UPS are not affected and can continue utilize this API till its EOL in June 2024. Adobe Commerce 2.4.7 will come with upgraded UPS REST API instead.
Great, thank you for the info @chernenm . Will look forward to that in the 2.4.7 release coming up soon.
Plz give link of any 3rd party that giving ups with Magento
On Fri, 2 Jun 2023, 23:08 Ryan Hoerr, @.***> wrote:
This is a major S0 issue that Adobe will need to address in the immediate future.
The immediate impact is that starting this coming Monday, June 5 2023, merchants will no longer be able to add UPS rates to Magento. UPS will no longer generate any XML API keys, which Magento requires.
The long-term impact is that as of June 2024, every merchant that uses Magento's native UPS rate connector will no longer get rates from UPS. This has a high probability of breaking checkout, as most US merchants do not offer multiple parcel shipment providers.
Until this is resolved in Magento core, Merchants have the option of switching to a third party provider for their UPS rates, but that involves additional costs and setup. That's not an acceptable solution in the broad picture.
— Reply to this email directly, view it on GitHub https://github.com/magento/magento2/issues/37534#issuecomment-1574089907, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3VJ3B53BUYX7O5MM5DJALXJIQK7ANCNFSM6AAAAAAYNFKIWY . You are receiving this because you commented.Message ID: @.***>
Seriously, this is not a joke! Something needs to be done about this, now. There is no point in using Magento if it can't calculate shipping. If this doesn't get fixed soon, I foresee a mass exodus from Magento.
hello @ihaveathumb, @techguysourav, Please check the official UPS extension at Magento marketplace https://marketplace.magento.com/ups-shipping.html while Adobe is working on a solution for out of the box integration.
@chernenm Is the message at the top of that extension listing still applicable?
IMPORTANT NOTE: This extension is currently available for merchants in POLAND, FRANCE, UNITED KINGDOM, GERMANY, ITALY, SPAIN, NETHERLANDS and BELGIUM ONLY. It will be available for merchants in other countries soon. At this time, please only install this extension if you are in the above-mentioned countries.
Also, when will 2.4.7 with the UPS REST API be released? There's not currently any published release date for 2.4.7, which suggests it won't be until sometime in 2024. That's cutting it close for the many merchants that will need to update.
Thanks
hi @rhoerr,
The API update is planed to be included into 2.4.7-beta2 version which scheduled for October 2023. In addition we are working on a hotfix for new 2.4.6 customers and ensuring that UPS extension documentation is up to date at Magento marketplace.
hello @ihaveathumb, @techguysourav, Please check the official UPS extension at Magento marketplace https://marketplace.magento.com/ups-shipping.html while Adobe is working on a solution for out of the box integration.
That doesn't work for me, because I'm not in the very few countries that it supports.
This is an issue as UPS will no longer generate keys and the extension on marketplace isn't for the USA! So if you don't have keys then no UPS on your Magento site. Not good at all.
Hello, @maxq,
Adobe is currently working on the solution for this issue, we will be releasing a hotfix for 2.4.4, 2.4.5 and 2.4.6 customers.
When, though? This is taking way too long for an issue that you knew far ahead of time was going to happen!!!
On Thu, Aug 3, 2023, 5:29 PM chernenm @.***> wrote:
Hello, @maxq https://github.com/maxq,
Adobe is currently working on the solution for this issue, we will be releasing a hotfix for 2.4.4, 2.4.5 and 2.4.6 customers.
— Reply to this email directly, view it on GitHub https://github.com/magento/magento2/issues/37534#issuecomment-1664670248, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQJYIRNP2OENNRYNMIDBOTXTQJ35ANCNFSM6AAAAAAYNFKIWY . You are receiving this because you were mentioned.Message ID: @.***>
Hello @joemstar,
The fix will be published tomorrow, September 14 around noon CST at https://experienceleague.adobe.com/docs/commerce-knowledge-base/kb/overview.html?lang=en
The fix is available here https://experienceleague.adobe.com/docs/commerce-knowledge-base/kb/troubleshooting/known-issues-patches-attached/ups-shipping-method-integration-migration-from-soap-to-restful-api.html
hello @laconica-vasilij, the patch is only applicable for supported versions of Adobe Commerce and Magento Open Source which are 2.4.4+
Applied the patch, anyone know how to get credentials from UPS?
Look at the instructions https://developer.ups.com/get-started. You need to create an application to receive API keys
Their API signup is so bad you go through all the steps then get this. There is a non-technical issue with your request, in order to resolve it you will need to complete and submit the requested information. [Click Here to Resolve] so you click on it and get HTTP 400 bad request.
See this stuff so much nowadays wonder who's coding this stuff.
Also love this little gem.
Did this work for anyone? I applied patch to 2.4.5 but getting an error
I pin pointed the issue and it looks like its related to the fact that response is not sending any shipping codes like the following.
Instead response from UPS is coming back as this
Which does not match up with anything that we have in Magento
@timur-gafarov-acadaca I have tried to reproduced this on 2.4.5 on both local and cloud instance to be sure, but the issue is not there . I see the UPS methods with shipping rates.
The codes that you are seeing are the UPS Rating API response that we get back after the rating request, here is a chunked sample from response:
"RatedShipment": [ { "Disclaimer": { "Code": "05", "Description": "Rate excludes VAT. Rate includes a fuel surcharge, but excludes taxes, duties and other charges that may apply to the shipment." }, "Service": { **"Code": "01",** "Description": "" }, "RatedShipmentAlert": [ { "Code": "119001", "Description": "Additional Handling has automatically been set on Package 1." }, { "Code": "110971", "Description": "Your invoice may vary from the displayed reference rates" } ], "BillingWeight": { "UnitOfMeasurement": { "Code": "LBS", "Description": "Pounds" }, "Weight": "100.0" }, "TransportationCharges": { "CurrencyCode": "USD", "MonetaryValue": "321.11" }, "ServiceOptionsCharges": { "CurrencyCode": "USD", "MonetaryValue": "32.50" }, "TotalCharges": { "CurrencyCode": "USD", "MonetaryValue": "353.61" }, "NegotiatedRateCharges": { "TotalCharge": { "CurrencyCode": "USD", "MonetaryValue": "181.75" } }, "GuaranteedDelivery": { "BusinessDaysInTransit": "1", "DeliveryByTime": "10:30 A.M." }, "RatedPackage": { "TransportationCharges": { "CurrencyCode": "USD", "MonetaryValue": "321.11" }, "ServiceOptionsCharges": { "CurrencyCode": "USD", "MonetaryValue": "32.50" }, "TotalCharges": { "CurrencyCode": "USD", "MonetaryValue": "353.61" }, "Weight": "100.0", "BillingWeight": { "UnitOfMeasurement": { "Code": "LBS", "Description": "Pounds" }, "Weight": "100.0" } } }]
The Allowed methods are the methods that are mapped with the response codes under the UPS module using a helper configuration. Please explain your concern if any regarding the codes and give us the steps on how the issue is coming for you.
@glo05363 I was doing testing in admin, so possibly only admin is broken. Can you pls also try placing order via Admin?
@timur-gafarov-acadaca I have checked using admin interface and i can see the Rates data, Please check your configuration settings .
@glo05363 I double checked the code and pretty sure there is a bug somewhere. Via XDEBUG I found the place where UPS codes are being compared with local Magento codes.
vendor/magento/module-ups/Model/Carrier.php:1346
Here its looking for 01 code in the list of Magento codes that don't map to this format. In this screenshot you can see values of allowed methods array which stores codes differently in alphanumeric format.
Configuration settings look fine as I am able to get a similar response from UPS like you pasted before. The problem is that its not getting processed correctly and possibly skipping process that you mentioned related to Helper mapper. Please make sure that your patch is applied and that settings are in fact using the new REST authentication method.