magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Removing non RFC3986 authorized characters

Open MeCapron opened this issue 1 year ago • 64 comments

Description (*)

This pull request aims to fully remove the usage of non-compliant RFC 3986.

Related Pull Requests

https://github.com/magento/magento2/pull/35885

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

Questions or comments

It was done and merged for the Encoder but not for the Decoder yet

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [x] All new or changed code is covered with unit/integration tests (if applicable)
  • [x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

MeCapron avatar May 23 '23 12:05 MeCapron

Hi @MeCapron. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar May 23 '23 12:05 m2-assistant[bot]

@magento run all tests

MeCapron avatar May 23 '23 12:05 MeCapron

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run WebAPI Tests

MeCapron avatar May 24 '23 14:05 MeCapron

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run Sample Data Tests

MeCapron avatar May 25 '23 07:05 MeCapron

Failed to run the builds. Please try to re-run them later.

@magento run Sample Data Tests B2B

MeCapron avatar May 25 '23 08:05 MeCapron

Failed to run the builds. Please try to re-run them later.

How can we add the sample data to be lanched?

MeCapron avatar May 25 '23 08:05 MeCapron

@magento run Sample Data Tests B2B, Sample Data Tests CE, Sample Data Tests EE

bgorski avatar May 26 '23 13:05 bgorski

Failed to run the builds. Please try to re-run them later.

@magento run Sample Data Tests B2B, Sample Data Tests CE, Sample Data Tests EE

bgorski avatar May 26 '23 19:05 bgorski

Failed to run the builds. Please try to re-run them later.

@magento run Sample Data Tests B2B, Sample Data Tests CE, Sample Data Tests EE

bgorski avatar May 26 '23 20:05 bgorski

Failed to run the builds. Please try to re-run them later.

@magento run all tests

bgorski avatar May 26 '23 20:05 bgorski

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run all tests

MeCapron avatar Jun 07 '23 08:06 MeCapron

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run all tests

MeCapron avatar Jun 29 '23 13:06 MeCapron

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run all tests

MeCapron avatar Jul 03 '23 12:07 MeCapron

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run all tests

MeCapron avatar Jul 03 '23 14:07 MeCapron

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run Functional Tests CE, Functional Tests EE

MeCapron avatar Jul 04 '23 07:07 MeCapron

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run Functional Tests CE, Functional Tests EE, WebAPI Tests

MeCapron avatar Jul 04 '23 08:07 MeCapron

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.