magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Add translatable text in address renderers

Open vacla opened this issue 2 years ago • 57 comments

Description (*)

Added translate tags around text that was not able to translate yet for address renderers

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#36942

Manual testing scenarios (*)

  1. Add translations for "VAT" other than English and switch store to that language.
  2. Add product to cart
  3. Go to the checkout fill in your address including VAT.
  4. In the payment/billing step you will see that VAT has the translation that you have set

Questions or comments

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [x] All new or changed code is covered with unit/integration tests (if applicable)
  • [x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [x] All automated tests passed successfully (all builds are green)

vacla avatar Mar 01 '23 23:03 vacla

Hi @vacla. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Mar 01 '23 23:03 m2-assistant[bot]

@magento run all tests

vacla avatar Mar 01 '23 23:03 vacla

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B,Integration Tests

vacla avatar Mar 02 '23 03:03 vacla

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B,Integration Tests

vacla avatar Mar 02 '23 08:03 vacla

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B,Integration Tests

vacla avatar Mar 02 '23 18:03 vacla

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

vacla avatar Mar 02 '23 20:03 vacla

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests EE,Functional Tests B2B

vacla avatar Mar 03 '23 20:03 vacla

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests EE

vacla avatar Mar 03 '23 22:03 vacla

@magento run Functional Tests EE

vacla avatar Mar 03 '23 22:03 vacla

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests EE

vacla avatar Mar 04 '23 09:03 vacla

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests EE

vacla avatar Mar 04 '23 11:03 vacla

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests EE

vacla avatar Mar 04 '23 12:03 vacla

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests EE

vacla avatar Mar 04 '23 15:03 vacla

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests EE

vacla avatar Mar 04 '23 19:03 vacla

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests EE

vacla avatar Mar 04 '23 21:03 vacla

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests EE

vacla avatar Mar 04 '23 23:03 vacla

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.