magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Filter category product name by store id

Open mirianfalconi opened this issue 2 years ago • 3 comments

Description (*)

According to https://github.com/magento/magento2/issues/36076

In the category grid we can see blank/missing products when ordering by name if the product has the name defined in multiple scopes.

To prevent duplicate products in the result query I defined the store id scope if exists, if not return the default scope id.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#36076

Manual testing scenarios (*)

  1. Steps to reproduce described in fixed issue https://github.com/magento/magento2/issues/36076.
  2. The above steps are missing multiple store views categories with the same products but different names

Questions or comments

The bug can be found easier with the original select, remember to change cat_index.store_id = 1 if we have multiple attribute names associated with different scopes in catalog_product_entity_varchar the select will return with repeated products

SELECT product_var.store_id, entity_id , product_var.value as name FROM catalog_product_entity AS e INNER JOIN cataloginventory_stock_status AS stockItem ON stockItem.product_id = e.entity_id AND stockItem.website_id = 0 AND stockItem.stock_id = 1 INNER JOIN catalog_category_product_index_store1 AS cat_index ON cat_index.product_id = e.entity_id AND cat_index.category_id = 14 AND cat_index.store_id = 1 INNER JOIN catalog_product_entity_varchar AS product_var ON product_var.row_id = e.row_id AND product_var.attribute_id = (SELECT attribute_id FROM eav_attribute WHERE entity_type_id=4 AND attribute_code='name') WHERE (e.created_in <= '1640995204') AND (e.updated_in > '1640995204')

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

mirianfalconi avatar Sep 22 '22 20:09 mirianfalconi

Hi @mirianfalconi. Thank you for your contribution Here are some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

:information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Sep 22 '22 20:09 m2-assistant[bot]

@magento run all tests

mirianfalconi avatar Sep 22 '22 20:09 mirianfalconi

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

mirianfalconi avatar Sep 26 '22 15:09 mirianfalconi

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

mirianfalconi avatar Sep 29 '22 17:09 mirianfalconi

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.