magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Creditmemo Creation Error in 2.4.5: Please enter positive number in this field

Open Darkwolf81 opened this issue 2 years ago • 8 comments

Preconditions and environment

  • Magento 2.4.5
  • PHP 7.4.21 (Amazon AWS Elastic Beanstalk Platform, Nginx)

Steps to reproduce

  1. Create a creditmemo for any order
  2. Error Message: Please enter positive number in this field

Expected result

Creditmemo successfully created

Actual result

Error Message: Please enter positive number in this field In the input field, there is the formatted number with currency symbol instead only the number. That causes the error.

Additional information

It is the same error from here, that was first in 2.4.3 and fixed in 2.4.4: https://github.com/magento/magento2/issues/34182

Error is not reproducable on every system configuration. On my local development Server with Apache it workes fine. When i use the file: vendor/magento/module-directory/Currency.php from Magento 2.4.4, it works again. There were changes that broke it again.

It maybe helpful to look into the other issue to reproduce the issue.

Release note

No response

Triage and priority

  • [X] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Darkwolf81 avatar Sep 21 '22 20:09 Darkwolf81

Hi @Darkwolf81. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Sep 21 '22 20:09 m2-assistant[bot]

@magento give me 2.4-develop instance

Darkwolf81 avatar Sep 21 '22 20:09 Darkwolf81

Hi @Darkwolf81. Thank you for your request. I'm working on Magento instance for you.

Hi @Darkwolf81, here is your Magento Instance: https://4e8ce5105d66ecdd9c7c1c3c7ef0e146.instances.magento-community.engineering Admin access: https://4e8ce5105d66ecdd9c7c1c3c7ef0e146.instances.magento-community.engineering/admin_e34c Login: 30aa2fb0 Password: 7f69745f0da6

Hi, i cannot reproduce the error on the test Magento Instance. This has a system configuration, thats not affected by the error. The error in 2.4.3 could although not being reproduced on the Test Instance.

Darkwolf81 avatar Sep 21 '22 20:09 Darkwolf81

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • [ ] 5. Add label Issue: Confirmed once verification is complete.

  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Sep 22 '22 11:09 m2-assistant[bot]

Hi @Darkwolf81 , Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop and Magento 2.4.5 open source versions as well but the issue is not reproducible. As per the pre conditions mentioned by you, PHP 7.4 is not a supported version for Magento 2.4.5. Kindly check the Magento System requirements for compatible softwares and its supported versions to use Magento. Also check if the issue occured due to 3rd party extension / modules enabled and elaborate the steps / configuration details if you are still facing any issues. Thank you.

engcom-November avatar Sep 22 '22 11:09 engcom-November

Hi @Darkwolf81 , Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop and Magento 2.4.5 open source versions as well but the issue is not reproducible. As per the pre conditions mentioned by you, PHP 7.4 is not a supported version for Magento 2.4.5. Kindly check the Magento System requirements for compatible softwares and its supported versions to use Magento. Also check if the issue occured due to 3rd party extension / modules enabled and elaborate the steps / configuration details if you are still facing any issues. Thank you.

Hello @engcom-November Magento 2.4.4 added compatibility with PHP 8.1, but it is no requirement. Fresh install of 2.4.5 is still possible. Current composer.json has the requirement:

"require": {
        "php": "~7.4.0||~8.1.0",

PHP 8.1 is although currently not available on Amazon AWS, so max 8.0 is possible to use.

Maybe other users can confirm the issue, too. I can only confirm that the error affected through changes in the file described in the issue.

Regards, Andreas

Darkwolf81 avatar Sep 22 '22 16:09 Darkwolf81

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • [ ] 5. Add label Issue: Confirmed once verification is complete.

  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Dec 13 '22 06:12 m2-assistant[bot]

Hello @Darkwolf81,

Thanks for the reporting and collaboration!

We have tried to reproduce the issue in the Magento 2.4.5 as well as the 2.4-develop branch but the issue is not reproducible for us. When we tried it with PHP 7.4 we are getting the following fatal error:

PHP7 4 - Error

and with PHP 8.1 we are able to create the credit memo:

image

please let us know if in any specific condition you are getting this error.

Thanks

engcom-Hotel avatar Dec 13 '22 06:12 engcom-Hotel

Dear @Darkwolf81,

We have noticed that this issue has not been updated for a period of 14 Days. Hence we assume that this issue is fixed now, so we are closing it. Please raise a fresh ticket or reopen this ticket if you need more assistance on this.

Regards

engcom-Hotel avatar Dec 27 '22 05:12 engcom-Hotel