magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

typo error on a js file.

Open Oscarvaz96 opened this issue 2 years ago • 2 comments

Summary (*)

On Magento 2.3.5 there is a typo error right here: vendor/magento/module-catalog/view/frontend/web/js/product/storage/storage-service.js line 120: /** * Subscribers list */ subsctibers = {}; this object subsctibers = {}; is used in further parts of this js with that same name, which is a typo.

Examples (*)

line 191 processSubscribers: function (initialized, config) { if (subsctibers[config.namespace]) { _.each(subsctibers[config.namespace], function (callback) { callback(initialized); });

                delete subsctibers[config.namespace];
            }
        },

Proposed solution

It should be replaced by subscribers

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • [ ] Severity: S0 - Affects critical data or functionality and leaves users with no workaround.
  • [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [x] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Oscarvaz96 avatar Sep 20 '22 03:09 Oscarvaz96

Hi @Oscarvaz96. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Sep 20 '22 03:09 m2-assistant[bot]

@magento i am working on this

sandy6666 avatar Sep 21 '22 10:09 sandy6666

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • [ ] 5. Add label Issue: Confirmed once verification is complete.

  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Sep 26 '22 12:09 m2-assistant[bot]

Hi @Oscarvaz96

Thank you for reporting and collaboration.

we have tried to reproduce the issue in Magento 2.4-develop branch. And the issue is reproducible for us. we haved checked the storage-service.js file as mentioned above lines and in other places. we found the typo error.

Screenshot 2022-09-26 at 6 24 15 PM Screenshot 2022-09-26 at 6 24 32 PM Screenshot 2022-09-26 at 6 27 36 PM

Hence confirming the issue.

Thanks.

engcom-Delta avatar Sep 26 '22 12:09 engcom-Delta

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-6754 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Sep 27 '22 12:09 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Sep 27 '22 12:09 m2-assistant[bot]