magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Issue 33767: Product price updated using Manage Base Price API is not…

Open rogerdz opened this issue 2 years ago • 9 comments

Description (*)

Price saved per store view when Catalog Price Scope global

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#33767

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

rogerdz avatar Sep 15 '22 16:09 rogerdz

Hi @rogerdz. Thank you for your contribution Here are some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

:information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Sep 15 '22 16:09 m2-assistant[bot]

@magento run all tests

rogerdz avatar Sep 15 '22 16:09 rogerdz

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Hi @edenduong, I added unit test

rogerdz avatar Sep 19 '22 09:09 rogerdz

@magento run all tests

rogerdz avatar Sep 19 '22 09:09 rogerdz

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

:heavy_check_mark: QA Passed

Preconditions: Install fresh Magento 2.4-develop

Manual testing scenario:

  1. Generate Admin access token using POST request: storeurl/rest/default/V1/integration/admin/token
  2. Send POST API request for sync product: storeurl/rest/V1/products/base-prices. (Update Price using below Payload): Payload:
{
  "prices": [
    {
      "price": 85.67,
      "store_id": 1,
      "sku": "Test PRice"
    }
  ]
}
  1. Reindex and clear cache
  2. Navigate to Front-end -> Verify Price in Search Results page and Product Details page Issue 1: Price updated through API is getting updated in Front-end Product Details page only but not getting updated in
  3. Catalog Search Results page and Admin - Products page
  4. Navigate to Admin - Catalog - Products - Edit same Product - Update new price say ex: 90 and save
  5. Reindex and clear cache
  6. Navigate to front-end - Product Details page Issue 2: New Price updated from Admin panel is not getting updated in Front-end product details page (Old value saved using API is displayed in Front-end Product Details page) In my case Issue 2 is not reproducible. Before: :heavy_multiplication_x: Price was not getting updatd in the frontend as well as in admin. Screenshot 2022-09-21 at 1 27 35 PM

image

After: :heavy_check_mark:
Admin: image

Product page: image

Since automation is covered no additional manual test case is required to be added.

engcom-Lima avatar Sep 21 '22 09:09 engcom-Lima

Looking like bot has moved this ticket accidently from Merge In progress to Ready for testing. Hence, moving back to merge in progress.

engcom-Lima avatar Sep 26 '22 06:09 engcom-Lima