magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Issue 36101: Category selection tree in edit product is not in the sa…

Open rogerdz opened this issue 2 years ago • 9 comments

…me order as set in Catalog->Categories

Description (*)

Category selection tree in edit product is not in the same order as set in Catalog->Categories

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#36101

Manual testing scenarios (*)

  1. Create a new category under Catalog->Categories
  2. Move the new category to the top of the tree
  3. Edit a product and click on the Categories select... drop down

Questions or comments

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

rogerdz avatar Sep 07 '22 09:09 rogerdz

Hi @rogerdz. Thank you for your contribution Here are some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

:information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Sep 07 '22 09:09 m2-assistant[bot]

@magento run all tests

rogerdz avatar Sep 07 '22 09:09 rogerdz

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

rogerdz avatar Sep 08 '22 08:09 rogerdz

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@edenduong I fixed the unit test. @magento run all tests

rogerdz avatar Sep 09 '22 16:09 rogerdz

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

rogerdz avatar Sep 23 '22 06:09 rogerdz

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

:heavy_check_mark: QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

  1. Create a new category under Catalog->Categories
  2. Move the new category to the top of the tree
  3. Edit a product and click on the Categories select... drop down

Before: :heavy_multiplication_x: Category was not displaying in correct order during product edit. Category creation page: Screenshot 2022-12-20 at 12 30 30 PM

Product edit page: Screenshot 2022-12-20 at 12 29 55 PM

After: :heavy_check_mark: Now it is working fine.

Category creation page: Screenshot 2022-12-20 at 1 05 51 PM

Product edit page: Screenshot 2022-12-20 at 1 06 29 PM

Several builds are failed. Hence, moving this PR to extended testing.

engcom-Lima avatar Dec 20 '22 07:12 engcom-Lima

@magento give me 2.4-develop instance

engcom-Charlie avatar Jul 09 '24 10:07 engcom-Charlie

Hi @engcom-Charlie. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Charlie, here is your Magento Instance: https://fd6abf361e7cbefe41846db465b5b1ae.instances-prod.magento-community.engineering Admin access: https://fd6abf361e7cbefe41846db465b5b1ae.instances-prod.magento-community.engineering/admin_8d0c Login: ae39582e Password: 9b59e19624d3

It seems bot moved it from Extended Testing to Testing hence moving it back.

engcom-Charlie avatar Jul 09 '24 13:07 engcom-Charlie

@magento give me 2.4-develop instance

engcom-Charlie avatar Jul 10 '24 06:07 engcom-Charlie

Hi @engcom-Charlie. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Charlie, here is your Magento Instance: https://fd6abf361e7cbefe41846db465b5b1ae.instances-prod.magento-community.engineering Admin access: https://fd6abf361e7cbefe41846db465b5b1ae.instances-prod.magento-community.engineering/admin_4359 Login: 4cfedd86 Password: 4c58f1da2094

@magento run all tests

engcom-Charlie avatar Jul 10 '24 09:07 engcom-Charlie

@magento give me test instance

engcom-Charlie avatar Jul 10 '24 09:07 engcom-Charlie

Hi @engcom-Charlie. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Charlie, here is your Magento Instance: https://3d060ed20ba5831e5bf5ed9a82a91cb0.instances-prod.magento-community.engineering Admin access: https://3d060ed20ba5831e5bf5ed9a82a91cb0.instances-prod.magento-community.engineering/admin_9e6c Login: 54bf4c31 Password: 438e9f2cb548

@magento run Static Tests, Unit Tests, Functional Tests B2B, Functional Tests CE, Functional Tests EE

engcom-Charlie avatar Jul 11 '24 05:07 engcom-Charlie

@magento run all tests

engcom-Charlie avatar Jul 11 '24 09:07 engcom-Charlie

@magento run all tests

engcom-Charlie avatar Jul 12 '24 05:07 engcom-Charlie