magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] Set shared=false for SortOrderBuilder

Open m2-assistant[bot] opened this issue 2 years ago • 3 comments

This issue is automatically created based on existing pull request: magento/magento2#35848: Set shared=false for SortOrderBuilder


Using a shared instance for this builder easily causes unwanted side effects

Description (*)

The builders do not need to be shared as per their definition. If a builder is shared, it can causes side effects. While the actual effect was not reproducible on a vanilla Magento instance, the bug is quite obvious.

In our case the sorting of the customer grid in the admin panel did not have any effect, because the UiComponent building process interfered with \Magento\Customer\Model\GroupManagement::getLoggedInGroups

Manual testing scenarios (*)

I was not able to reproduce this on Vanilla Magento.

On our instance the repro steps were like this:

  1. Click title in custom grid to sort the list
  2. Does not have any effect

Questions or comments

I hope this does not go the good old "can reproduce" loop. The issue should be clear. Please merge.

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar Aug 12 '22 11:08 m2-assistant[bot]

Why is this assigned to me? What do I need to do?

amenk avatar Aug 12 '22 11:08 amenk

Hi @amenk ,

Thanks for your contribution and collaboration.

I have created this issue. As per our process for any pull request we should have corresponding issue and related jira ticket (after the confirmation of the issue). As you have created PR bot automatically assigned it to your name.

Also, please provide me information about the manual steps to reproduce the issue.

Thanks

engcom-Lima avatar Aug 12 '22 11:08 engcom-Lima

Hi,

It is so far for me only reproducible with customized extensions; the steps are there already (customer grid doesn't sort)

The solution should be pretty clear and can be merged if no tests fails, I hope.

amenk avatar Aug 12 '22 11:08 amenk

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-6442 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Aug 22 '22 12:08 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Aug 22 '22 12:08 m2-assistant[bot]