magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Converted magento magento2 30090 2.3.7

Open mrtuvn opened this issue 2 years ago • 13 comments

Description (*)

This merge for create patch magento 2.3.x use fixes speedup SCD process pipelines @ihor-sviziev can you share the patch link (if it's exist)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

mrtuvn avatar Aug 10 '22 00:08 mrtuvn

Hi @mrtuvn. Thank you for your contribution Here are some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3.7-release instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

:information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Aug 10 '22 00:08 m2-assistant[bot]

Further question Is this cover deploy compact strategy ?

mrtuvn avatar Aug 10 '22 04:08 mrtuvn

See this note in 2.4.5 release details but i'm not sure what code commit changed? Not mention ticket

The bin/magento setup:static-content:deploy -s compact command now includes styles from child themes as expected. Previously, theme CSS files were not present on the storefront after deployment.

mrtuvn avatar Aug 10 '22 05:08 mrtuvn

@magento run all tests

ihor-sviziev avatar Aug 10 '22 07:08 ihor-sviziev

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run WebAPI Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B, Integration Tests

mrtuvn avatar Aug 10 '22 12:08 mrtuvn

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

cc: @sidolov @sdzhepa

mrtuvn avatar Aug 11 '22 02:08 mrtuvn

Hi @mrtuvn, In order to merge this pull request, all tests should be passed and description should be in special format. Example https://github.com/magento/magento2/pull/34529

ihor-sviziev avatar Aug 11 '22 03:08 ihor-sviziev

This one i think neccessary for old stores used CE or EE version below range between 2.3.x to 2.4

mrtuvn avatar Aug 16 '22 06:08 mrtuvn

@magento run all tests

mrtuvn avatar Aug 16 '22 06:08 mrtuvn

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Hey @mrtuvn

Unfortunately we are unable to accept any Pull Requests to releases or branches other than current 2.4-develop therefore I have to close this PR for now.

Please feel free to reopen this PR for current release branch if you think issue is still there.

ishakhsuvarov avatar Aug 17 '22 13:08 ishakhsuvarov

This one not create any changes to current repo. This port create patch to https://github.com/magento/quality-patches @ishakhsuvarov

mrtuvn avatar Aug 17 '22 14:08 mrtuvn