magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Accept any throwable exceptions in newrelic wrapper

Open rmsundar1 opened this issue 2 years ago • 6 comments

Description (*)

In the current newrelic wrapper class, we are can capture only the \Exceptions however when we try to capture any TypeError it's giving the below exception

[2022-07-26T17:21:39.757093+00:00] report.CRITICAL: TypeError: Argument 1 passed to Magento\NewRelicReporting\Model\NewRelicWrapper::reportError() must be an instance of Exception, instance of TypeError given

NewRelic agent supports capturing any kind of Throwable errors ref: https://docs.newrelic.com/docs/apm/agents/php-agent/php-agent-api/newrelic_notice_error, so upgraded the NewRelicWrapper class to support any throwable type exceptions.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#35854

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • [X] Pull request has a meaningful description of its purpose
  • [X] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

rmsundar1 avatar Aug 01 '22 19:08 rmsundar1

Hi @rmsundar1. Thank you for your contribution Here are some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

:information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Aug 01 '22 19:08 m2-assistant[bot]

@magento run all tests

rmsundar1 avatar Aug 02 '22 12:08 rmsundar1

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests CE

rmsundar1 avatar Aug 02 '22 17:08 rmsundar1

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

:heavy_check_mark: QA Passed

Descrption: NewRelic Wrapper is not allowing to capture TypeError Preconditions: Fresh Magento should be installed

Manual testing scenario:

  1. Go to app/code/Magento/NewRelicReporting/Model/NewRelicWrapper.php in code base.
  2. Check the function:reportError

Before: :heavy_multiplication_x: image

After: :heavy_check_mark: image

engcom-Lima avatar Aug 12 '22 10:08 engcom-Lima