Display zero tax configuration does not work in case of multiple shipping methods on Cart page

[pranayhbwsl]

Preconditions and environment

• Magento version 2.4.2

Steps to reproduce

1. Enable multiple delivery methods by navigating to Stores -> Configuration -> Sales -> Delivery Methods.
2. Set 'Display Zero Tax Subtotal' to 'No' by navigating to Stores -> Configuration -> Sales -> Tax -> Shopping Cart Display Settings.
3. Visit storefront without signing in, add a product to cart and check shopping cart. Zero tax field is visible untill we chose a shipping method.

Expected result

Tax field with value 0.00 should not be visible in cart totals before selecting shipping methods.

Actual result

Tax field with value 0.00 is visible even before selecting shipping method.

Additional information

This issue happens because of strict equals operator in -> vendor/magento/module-tax/view/frontend/web/js/view/checkout/cart/totals/tax.js on line 24.

If we change it '==' the value '0.00' will also satisfy this condition and hide the tax field.

Same operator i.e., '==' is used in vendor/magento/module-tax/view/frontend/web/js/view/checkout/summary/tax.js for tax field zero value display check.

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [X] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @pranayhbwsl. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant[bot]]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• [ ] 5. Add label Issue: Confirmed once verification is complete.

• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Verified the issue on Magento 2.4-develop branch and the issue is reproducible. tax:0 is displayed in shopping cart page if shipping method is not selected. After shipping method is selected in checkout page and navigated back to shopping cart page, tax:0 is not displayed.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-3201 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[mmezhensky]

@magento I am working on this

[engcom-Lima]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Lima, here is your Magento Instance: https://1ee831d03ca92acb82a353361041180d.instances.magento-community.engineering Admin access: https://1ee831d03ca92acb82a353361041180d.instances.magento-community.engineering/admin_2f30 Login: dfe4fbc8 Password: e11ea201b2f6

[isxam]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @isxam. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @isxam, here is your Magento Instance: https://1ee831d03ca92acb82a353361041180d.instances.magento-community.engineering Admin access: https://1ee831d03ca92acb82a353361041180d.instances.magento-community.engineering/admin_59fd Login: 1aed8509 Password: 0918bd3a7a46

[engcom-Hotel]

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-3201 by the internal team Related commits: https://github.com/search?q=AC-3201&type=commits

Based on the Jira ticket, the target version is 2.4.6.

Thanks