magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Remote Storage Error

Open Nuranto opened this issue 3 years ago • 6 comments

Preconditions (*)

  1. Magento 2.4.3-p1
  2. Remote storage enabled (S3)

Steps to reproduce (*)

  1. Delete a product image directly in S3 to simulate a missing file
  2. Load the related product edit page.

Expected result (*)

  1. Image is not displayed.

Actual result (*)

  1. Product form is not displayed, error instead : Notice: Undefined index: media/catalog/product/t/e/test-inexistant-image.jpg in /var/www/html/vendor/magento/module-remote-storage/Driver/Adapter/Cache/Generic.php on line 197

Proposed patch

Replace if (!$meta[$path]) { with if (!($meta[$path] ?? false)) {


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Nuranto avatar Jan 20 '22 10:01 Nuranto

Hi @Nuranto. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Jan 20 '22 10:01 m2-assistant[bot]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • [ ] 5. Add label Issue: Confirmed once verification is complete.

  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Aug 02 '22 10:08 m2-assistant[bot]

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • [ ] 5. Add label Issue: Confirmed once verification is complete.

  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Aug 09 '22 09:08 m2-assistant[bot]

Hello @Nuranto,

Thanks for the reporting!

We have tried to reproduce the issue in the Magento 2.4-develop branch but the issue is not reproducible for us. After deleting the image from S3 directly, we have an empty box instead of that image. Please have a look at the below screenshot for reference:

image

Please let us know in case we have missed anything.

Thanks

engcom-Hotel avatar Aug 09 '22 09:08 engcom-Hotel

Hello @engcom-Hotel

Just to be sure, have you tried to purge cache ? Because remote-storage file's metadatas are stored in cache. (Btw, I think they should not be cached, but that's another issue : https://github.com/magento/magento2/issues/35820 :)

Nuranto avatar Aug 09 '22 13:08 Nuranto

Hello @Nuranto,

Thanks for the reply!

We have tried this after clearing the cache as well. But the outcome is the same as mentioned in this comment https://github.com/magento/magento2/issues/34997#issuecomment-1209111738.

Please let us know in case we have missed anything.

Thanks

engcom-Hotel avatar Aug 10 '22 11:08 engcom-Hotel

Dear @Nuranto,

We have noticed that this issue has not been updated for a period of 14 Days. Hence we assume that this issue is fixed now, so we are closing it. Please raise a fresh ticket or reopen this ticket if you need more assistance on this.

Regards

engcom-Hotel avatar Aug 24 '22 05:08 engcom-Hotel