magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

fixed status if status is null in order comment update RESTAPI

Open bireney opened this issue 3 years ago • 5 comments

Description (*)

Fixed : RestAPI add order comment without providing status sets status to NULL, preventing from showing in order grid #34180

Fixed Issues (if relevant)

  1. Fixes magento/magento2#34180

Manual testing scenarios (*)

  1. Created order in magento and updated the comment excluded "status" field using RestAPI postman. So order comment updated with given data also order status is existing status.
  2. Updated the order with comment and different status and its also updating perfectly.
  3. Updated order comment with NULL status and its also taking the existing order status.

Questions or comments

Contribution checklist (*)

  • [*] Pull request has a meaningful description of its purpose
  • [*] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

bireney avatar Jan 19 '22 06:01 bireney

Hi @bireney. Thank you for your contribution Here are some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

:information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Jan 19 '22 06:01 m2-assistant[bot]

@magento run all tests

nuzil avatar Jan 21 '22 15:01 nuzil

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

nuzil avatar Feb 21 '22 13:02 nuzil

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Static Tests ,Functional Tests EE

engcom-Lima avatar Sep 26 '22 13:09 engcom-Lima

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Static Tests

engcom-Lima avatar Sep 27 '22 07:09 engcom-Lima

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Static Tests

engcom-Lima avatar Sep 27 '22 07:09 engcom-Lima

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Hi @bireney ,

Thanks for your contribution and collaboration.

I have tested this PR . Now, I am not getting order status as NULL(reported issue) in DB and order is getting displayed in the frontend. But what I observed is comment is not getting updated in Admin - View Order - Comment. I have seen this comment in issue it is mentioned that "Comment is not getting updated in the admin".

So, I want clarification from your side like if this PR fixes this issue -->> Comment is not getting updated in the Admin Grid. Please provide us information on above query as soon as possible.

Screenshot for your reference: image

Thanks

engcom-Lima avatar Sep 27 '22 10:09 engcom-Lima

Closing this PR for now due to inactivity.

Please reopen if you would like to address manual verification comments or work on it any further.

Thanks!

ishakhsuvarov avatar Oct 20 '22 18:10 ishakhsuvarov