magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Admin Grid selection issue - Magento 2.3.4

Open JDhere opened this issue 3 years ago • 40 comments

Preconditions (*)

  1. Magento Version 2.4.3.
  2. Have some orders in sales order add.

Steps to reproduce (*)

  1. Go to admin panel->Sales->Orders
  2. Search for a particular increment id in the search bar.
  3. Then the result of that order field will be displayed(1 result).
  4. Select the rendered result.
  5. Now search for another increment id in the search bar
  6. Select the displayed result
  7. Clear all the filters
  8. It will move to the original grid view, now all the checkboxes will be deselected

Expected result (*)

  1. The grid should select only the selected result and keep all other fields unchecked.

Actual result (*)

  1. When the admin grid is rendered after removing the filters it deselects all the selected orders

PS

As discussed in the comments, The issue is recreated in a different way in the latest magento release.

Magento Version: 2.4.3-p1

Steps to reproduce

  1. Go to Sales->Orders
  2. In the grid copy a increment id and paste it in the search field and perform search operation.
  3. Now select the record(only 1 will be displayed)
  4. Now remove the filter
  5. Now the selected record will be removed

Expected result

While removing the filter the selected record which was selected in the search operation should also be selected.

Actual Result

The selection is removed when the filter is removed.

Reproduced in Magento 2.4.x:

mageto-admin-grid-bug

And as discussed in the comments that this is not a bug and its the intended method, we need a solution to fix this or improvise this in future. Consider the use case scenario:

The user is changing the status of order by referring to his list.

The user opens the admin panel-> Then searches for an increment id-> Selects it-> Then again searches for an increment id-> selects it-> This goes on till his list is completed

Then he is performing the mass action eg: hold. So in this case the purpose of mass action will itself get failed with the current bug!


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • [x] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

JDhere avatar Jan 10 '22 10:01 JDhere

Hi @JDhere. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Jan 10 '22 10:01 m2-assistant[bot]

@magento give me 2.3.4 instance

JDhere avatar Jan 10 '22 10:01 JDhere

Hi @JDhere. Thank you for your request. I'm working on Magento instance for you.

Hi @JDhere, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

Hi @ajijshekh123. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • [ ] 5. Add label Issue: Confirmed once verification is complete.

  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Jan 10 '22 12:01 m2-assistant[bot]

Hi @JDhere , Verified the issue on Magento 2.4-develop branch but cannot able to reproduce the issue. Sales Orders Grid is displayed without check boxes selected after removing the Increment ID filter applied. Kindly verify the issue on Magento 2.4-develop branch and provide missing steps if any if the issue is still reproducible. Thank you.

engcom-November avatar Jan 10 '22 13:01 engcom-November

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • [ ] 5. Add label Issue: Confirmed once verification is complete.

  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Jan 10 '22 13:01 m2-assistant[bot]

@magento give me 2.4-develop instance

JasonTychons avatar Jan 11 '22 02:01 JasonTychons

Hi @JasonTychons. Thank you for your request. I'm working on Magento instance for you.

Hi @JasonTychons, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@magento give me 2.4-develop instance

JasonTychons avatar Jan 11 '22 05:01 JasonTychons

Hi @JasonTychons. Thank you for your request. I'm working on Magento instance for you.

Hi @JasonTychons, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

ezgif com-gif-maker (1)

I am able to reproduce the issue, but in a different manner. When the filter is remove it clears the selection which shouldn't have happened.

JDhere avatar Jan 11 '22 06:01 JDhere

@magento give me 2.4-develop instance

JDhere avatar Jan 11 '22 06:01 JDhere

Hi @JDhere. Thank you for your request. I'm working on Magento instance for you.

Hi @JDhere, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

Hi @JDhere , I believe this is an expected behavior but not a bug because when filter applied using any option with "Filters", due to filter being applied after page load, checkbox is deselected. Kindly recheck the behavior on 2.4-develop branch and let us know if you are still facing issues.

engcom-November avatar Jan 11 '22 12:01 engcom-November

Hi @engcom-November , I don't think that is an expected behaviour. Because consider the use case scenario:

  • The user is changing the status of order by referring to his list.

  • The user opens the admin panel-> Then searches for an increment id-> Selects it-> Then again searches for an increment id-> selects it-> This goes on till his list is completed

  • Then he is performing the mass action eg: hold.

  • So in this case the purpose of mass action will itself get failed with the current bug!

JDhere avatar Jan 11 '22 12:01 JDhere

@magento give me 2.4-develop instance

JDhere avatar Jan 11 '22 12:01 JDhere

Hi @JDhere. Thank you for your request. I'm working on Magento instance for you.

Hi @JDhere, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@magento give me 2.4-develop instance

JDhere avatar Jan 12 '22 06:01 JDhere

Hi @JDhere. Thank you for your request. I'm working on Magento instance for you.

Hi @JDhere, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@magento I am working on this

JDhere avatar Jan 12 '22 06:01 JDhere

Hi @JDhere! :wave: Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

m2-assistant[bot] avatar Jan 12 '22 06:01 m2-assistant[bot]

@magento add to contributors team

JDhere avatar Jan 12 '22 06:01 JDhere

Hi @JDhere! :wave: Thank you for joining. Please accept team invitation :point_right: here :point_left: and add your comment one more time.

m2-assistant[bot] avatar Jan 12 '22 06:01 m2-assistant[bot]

@magento I am working on this

JDhere avatar Jan 12 '22 06:01 JDhere