magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] Improve Bundle Option & Selection Data Extensibility

Open m2-assistant[bot] opened this issue 4 years ago • 4 comments

This issue is automatically created based on existing pull request: magento/magento2#34803: Improve Bundle Option & Selection Data Extensibility


Description (*)

Updated the visibility from private to public for the following functions in Magento\Bundle\Block\Catalog\Product\View\Type\Bundle for improved extensibiility:

  • getOptionItemData()
  • getSelectionItemData()

Manual testing scenarios (*)

  1. Create a new local module
  2. Create a before/after/around plugin for each of the aforementioned functions
  3. Configure the plugin in etc/di.xml
  4. Enable the module
  5. Enable and configure Xdebug and add breakpoints in your plugin(s)
  6. Load a bundle product page on the frontend
  7. Ensure the plugin(s) breakpoint(s) are hit

Questions or comments

I don't know why these were originally declared private functions so if there's a reason this change cannot be made, please let me know.

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [x] All new or changed code is covered with unit/integration tests (if applicable)
  • [x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar Dec 13 '21 11:12 m2-assistant[bot]

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • [ ] 5. Add label Issue: Confirmed once verification is complete.

  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Dec 14 '21 07:12 m2-assistant[bot]

HI @pykettk,

Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop instance and it is not a bug.It is an Improvement.

Hence we are considering this as a Feature Request.

Thanks.

engcom-Bravo avatar Jan 20 '23 10:01 engcom-Bravo

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-13239 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Oct 14 '24 13:10 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Oct 14 '24 13:10 m2-assistant[bot]

After having internal discussion, this issue has been marked as feature request and we need a PO confirmation for it so moving it on hold for now.

engcom-Dash avatar Nov 28 '24 07:11 engcom-Dash

As per Product Owner, currently we can not go ahead with this PR as its risky to expose these private methods, make it public. Hence closing this PR now.

Thank you!

engcom-Charlie avatar Jan 17 '25 14:01 engcom-Charlie