magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] Improve Bundle Option & Selection Data Extensibility

Open m2-assistant[bot] opened this issue 3 years ago • 4 comments

This issue is automatically created based on existing pull request: magento/magento2#34803: Improve Bundle Option & Selection Data Extensibility


Description (*)

Updated the visibility from private to public for the following functions in Magento\Bundle\Block\Catalog\Product\View\Type\Bundle for improved extensibiility:

  • getOptionItemData()
  • getSelectionItemData()

Manual testing scenarios (*)

  1. Create a new local module
  2. Create a before/after/around plugin for each of the aforementioned functions
  3. Configure the plugin in etc/di.xml
  4. Enable the module
  5. Enable and configure Xdebug and add breakpoints in your plugin(s)
  6. Load a bundle product page on the frontend
  7. Ensure the plugin(s) breakpoint(s) are hit

Questions or comments

I don't know why these were originally declared private functions so if there's a reason this change cannot be made, please let me know.

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [x] All new or changed code is covered with unit/integration tests (if applicable)
  • [x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar Dec 13 '21 11:12 m2-assistant[bot]