[Issue] Improve Bundle Option & Selection Data Extensibility
This issue is automatically created based on existing pull request: magento/magento2#34803: Improve Bundle Option & Selection Data Extensibility
Description (*)
Updated the visibility from private to public for the following functions in Magento\Bundle\Block\Catalog\Product\View\Type\Bundle for improved extensibiility:
getOptionItemData()getSelectionItemData()
Manual testing scenarios (*)
- Create a new local module
- Create a before/after/around plugin for each of the aforementioned functions
- Configure the plugin in
etc/di.xml - Enable the module
- Enable and configure Xdebug and add breakpoints in your plugin(s)
- Load a bundle product page on the frontend
- Ensure the plugin(s) breakpoint(s) are hit
Questions or comments
I don't know why these were originally declared private functions so if there's a reason this change cannot be made, please let me know.
Contribution checklist (*)
- [x] Pull request has a meaningful description of its purpose
- [x] All commits are accompanied by meaningful commit messages
- [x] All new or changed code is covered with unit/integration tests (if applicable)
- [x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- [ ] All automated tests passed successfully (all builds are green)
Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
-
[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the labelIssue: Format is validwill be added to the issue automatically. Please, edit issue description if needed, until labelIssue: Format is validappears. -
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add
Issue: Clear Descriptionlabel to the issue by yourself. -
[ ] 3. Add
Component: XXXXXlabel(s) to the ticket, indicating the components it may be related to. -
[ ] 4. Verify that the issue is reproducible on
2.4-developbranchDetails
- Add the comment@magento give me 2.4-develop instanceto deploy test instance on Magento infrastructure.
- If the issue is reproducible on2.4-developbranch, please, add the labelReproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here! -
[ ] 5. Add label
Issue: Confirmedonce verification is complete. -
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.
HI @pykettk,
Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop instance and it is not a bug.It is an Improvement.
Hence we are considering this as a Feature Request.
Thanks.
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-13239 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
After having internal discussion, this issue has been marked as feature request and we need a PO confirmation for it so moving it on hold for now.
As per Product Owner, currently we can not go ahead with this PR as its risky to expose these private methods, make it public. Hence closing this PR now.
Thank you!