magento2
magento2 copied to clipboard
New Checkout Shipping Address Has Company After Changing Show Company to No
I am unable to reopen issue #33663 so I am resubmitting the request here in hopes of clearing up the misunderstanding.
Steps to reproduce (*)
- In the admin panel, Customer Configuration - change Show Company to Optional, press Save Config, and then clear cache.
- Create a customer.
- Login as the customer and add separate billing and shipping addresses with a company on both.
- In the admin panel, change Customer Configuration - Show Company to No, press Save Config, and then clear cache.
- Front-end - Login as Customer - Add a product to Cart - Checkout - go to Payment Step - Go back again to Shipping step - Add different new Shipping Address and place Order
- In the Magento database, check the address in the sales_order_address table and in the customer_address_entity table.
Expected result (*)
- After placing the order, the shipping address should not have a shipping company on it on the customer address or on the order in the database.
Actual result (*)
- After placing the order, the shipping address has the previous shipping address's company on it in the database. You will only see it in the Magento database in the company field on the order and on the customer address.
Hi @moranotcsos. Thank you for your report. To help us process this issue please make sure that you provided the following information:
- Summary of the issue
- Information on your environment
- Steps to reproduce
- Expected and actual results
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release
For more details, please, review the Magento Contributor Assistant documentation.
Please, add a comment to assign the issue: @magento I am working on this
- Join Magento Community Engineering Slack and ask your questions in #github channel.
:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
:clock10: You can find the schedule on the Magento Community Calendar page.
:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.
:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel
:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel
Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
-
[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the labelIssue: Format is valid
will be added to the issue automatically. Please, edit issue description if needed, until labelIssue: Format is valid
appears. -
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add
Issue: Clear Description
label to the issue by yourself. -
[ ] 3. Add
Component: XXXXX
label(s) to the ticket, indicating the components it may be related to. -
[ ] 4. Verify that the issue is reproducible on
2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on2.4-develop
branch, please, add the labelReproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here! -
[ ] 5. Add label
Issue: Confirmed
once verification is complete. -
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.
Verified the issue on Magento 2.4-develop branch and the issue is not reproducible in DB as well: Steps performed:
- Stores - Configuration - Customers - Customer Configuration - Show Company - Set to Optional and Save
- Reindex and clear cache
- Create Customer Account from front end and sign in
- Added different Shipping Address and Billing Address for the customer from front-end/admin with Company name for both and saved.
- Stores - Configuration - Customers - Customer Configuration - Show Company - Set to No and Save
- Reindex and clear cache
- Login as Customer - Add a product to Cart - Checkout - Add different Shipping Address and placed Order
- Checked DB tables: sales_order_address and customer_address_entity tables
No issue: Company is NULL in both the tables
Note: This issue also not observed when Shipping and Billing Address are saved from Admin - Customers page Also note, This issue is not observed when logged in as Customer from admin (Customers - All Customers - Edit Customer - Login as Customer and placed order with different shipping address) @moranotcsos kindly recheck the issue on Magento 2.4-develop branch and provide missing steps if any if the issue is still reproducible. Thank you.
@engcom-November
I realized my mistake. For Step 7, it should be:
Login as Customer - Add a product to Cart - Checkout - Go to Payment Step - Go Back to Shipping Step - Add different Shipping Address and placed Order.
I was able to reproduce this on 2.4.3. Let me know if you are able to reproduce this now.
@engcom-November
I just wanted to follow up and confirm you received my previous response.
I realized my mistake and for Step 7, it should be:
Login as Customer -> Add a product to Cart -> Checkout -> Go to Payment Step -> Go Back to Shipping Step -> Add different Shipping Address and place order.
I was able to reproduce this on 2.4.3. Let me know if you are able to reproduce this now.
Verified the issue again on Magento 2.4-develop branch with missing steps provided and the issue is reproducible now: Steps to reproduce:
- Stores - Configuration - Customers - Customer Configuration - Show Company - Set to Optional and Save
- Reindex and clear cache
- Create Customer Account from front end and sign in
- Added different Shipping Address and Billing Address for the customer from front-end/admin with Company name for both and saved.
- Stores - Configuration - Customers - Customer Configuration - Show Company - Set to No and Save
- Reindex and clear cache
- Front-end - Login as Customer - Add a product to Cart - Checkout - go to Payment Step - Go back to Shipping step - Add different Shipping Address and place Order
8 Check DB tables: sales_order_address and customer_address_entity tables
Issue: After placing the order, the shipping address has the previous shipping address's company on it in the database
:white_check_mark: Confirmed by @engcom-November
Thank you for verifying the issue. Based on the provided information internal tickets MC-43097
were created
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
Hello,
I just wanted to follow up to see if there has been any progress on the matter. I see it's in the triage board and just wanted to check if we may be getting a patch soon. While it was replicated on 2.4.3, the client we have is on 2.4.1 (we can upgrade to 2.4.2-p2 if necessary) and upgrading to 2.4.3 is not possible with our current setup.
@magento I am working on this
Hi @jzarowny! :wave:
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team
command to join Contributors team.
@magento add to contributors team
Hi @jzarowny! :wave: Thank you for joining. Please accept team invitation :point_right: here :point_left: and add your comment one more time.
@magento I am working on this
Hello,
As I can see this issue got fixed in the scope of the internal Jira ticket AC-838 by the internal team Related commits: https://github.com/magento/magento2/search?q=AC-838&type=commits
Based on the Jira ticket, the target version is 2.4.6.
Thanks