Implemented addAttachment method to TransportBuilder

[dudzio12]

Description (*)

Implemented addAttachment method to TransportBuilder class which allows developers to add attachment to email messages.

Fixed Issues (if relevant)

1. Fixes magento/magento2#33261

Manual testing scenarios (*)

1. Tested transportBuilder without addAttachment usage.
2. Tested transportBuilder with addAttachment usage.

Contribution checklist (*)

• [ ] Pull request has a meaningful description of its purpose
• [ ] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ ] All automated tests passed successfully (all builds are green)

[m2-assistant[bot]]

Hi @dudzio12. Thank you for your contribution Here are some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[dudzio12]

I see you've blocked merging this PR #3803 because of usage Zend classes. Is that still an issue? You want me to rewrite those classes and implement it as part of Magento Core?

[danielrussob]

@magento give me test instance

[magento-deployment-service[bot]]

Hi @danielrussob. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @danielrussob, here is your Magento Instance: https://df10707f16c867d712e5aebaee49d146.instances.magento-community.engineering Admin access: https://df10707f16c867d712e5aebaee49d146.instances.magento-community.engineering/admin_5f6e Login: 767c4038 Password: 22a3288cf9b6

[danielrussob]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[aleron75]

Hello @dudzio12!

First of all, thank you for your contribution.

Due to Magento Definition of Done, all code must be covered by tests.

For this specific case, do you think it would be feasible to extend \Magento\Framework\Mail\TransportBuilderTest to add a test case that covers this new feature?

My best, Alessandro

[dudzio12]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[danielrussob]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[danielrussob]

@magento run Integration Tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[danielrussob]

@magento run Sample Data Tests CE

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[aleron75]

The semantic version test fails because new property & method has been introduced and it's correct, the QA team will take it into consideration when packaging the release.

We re-run the other failing tests because they seem flaky.

[dudzio12]

I've fixed issue when using TransportBuilder inside loop. It didn't reset attachment part, so on every next mail there were duplicated attachments.

I also changed integration test to implement new method.

[dudzio12]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[dudzio12]

@magento run Integration Tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[dudzio12]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[danielrussob]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[hostep]

Hi folks, what would be the status here?

Would be nice to have an easy way to add attachments to emails in core Magento 🙂

/cc @ishakhsuvarov, @sidolov

[dudzio12]

Branch was updated

[dudzio12]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.