magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Fix hard-coded scope store in codebase order model

Open mrtuvn opened this issue 4 years ago • 19 comments

Description (*)

Fix hard-coded store value used in code base

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

CC: @ihor-sviziev this one can be merge as quick as possible. Should not break any thing with this change

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

  1. [x] resolves magento/magento2#38420: Fix hard-coded scope store in codebase order model

mrtuvn avatar Feb 08 '21 05:02 mrtuvn

Hi @mrtuvn. Thank you for your contribution Here are some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Feb 08 '21 05:02 m2-assistant[bot]

@magento run all tests

mrtuvn avatar Feb 09 '21 04:02 mrtuvn

@magento run Functional Tests CE, Functional Tests B2B, Functional Tests EE

mrtuvn avatar Feb 09 '21 06:02 mrtuvn

@magento run Functional Tests CE, Functional Tests B2B

mrtuvn avatar Feb 09 '21 09:02 mrtuvn

@magento run Functional Tests B2B

mrtuvn avatar Feb 10 '21 02:02 mrtuvn

Hi @ihor-sviziev, thank you for the review. ENGCOM-8775 has been created to process this Pull Request :eight_spoked_asterisk: @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

magento-engcom-team avatar Feb 17 '21 10:02 magento-engcom-team

clean code no impact in my opinion. Auto tests may not required for such case

mrtuvn avatar Jan 18 '24 03:01 mrtuvn

@magento run all tests

mrtuvn avatar Jan 18 '24 07:01 mrtuvn

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento create issue

engcom-Delta avatar Feb 05 '24 14:02 engcom-Delta

failed tests seem not related from my updates. Others fails from exists code need works to clear

mrtuvn avatar Feb 06 '24 02:02 mrtuvn

@magento run all tests

engcom-Echo avatar Feb 20 '24 11:02 engcom-Echo

@magento run all tests

engcom-Echo avatar Feb 26 '24 14:02 engcom-Echo

@magento run Functional Tests CE,Functional Tests B2B

engcom-Echo avatar Feb 27 '24 03:02 engcom-Echo

@magento run Functional Tests B2B

engcom-Echo avatar Feb 27 '24 05:02 engcom-Echo