magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] Inconsistent labels for attributes in marketing rules

Open m2-assistant[bot] opened this issue 4 years ago • 10 comments

This issue is automatically created based on existing pull request: magento/magento2#31231: Inconsistent labels for attributes in marketing rules


Description (*)

In task MAGETWO-94407, functionality was added for correct operation of marketing rules with configurable products. But additional labels for attributes are inconsistent. Some of them do not contain spaces, and some have a different style of writing words, some uppercase, and some uppercase letters.

Related Pull Requests

https://github.com/magento/magento2/commit/db41fab1f19a86dc90d2fc922e48a4707d240e15#diff-f4e77b2225e395e85ad967f315970b77f1557e94c2033038091750b2d4e11382

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Create Cart Price Rule or Catalog Price Rule rule
  2. Add Product attribute combination section
  3. Сheck the category and attribute options

image

Questions or comments

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar Dec 09 '20 18:12 m2-assistant[bot]

Hi @krishprakash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • [ ] 5. Add label Issue: Confirmed once verification is complete.

  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Dec 25 '20 14:12 m2-assistant[bot]

@magento give me 2.4-develop instance

krishprakash avatar Dec 25 '20 14:12 krishprakash

Hi @krishprakash. Thank you for your request. I'm working on Magento instance for you.

Hi @krishprakash, here is your Magento Instance: https://9c1a7e30f4bf28b00fe5a2f41125e31a-2-4-develop.instances.magento-community.engineering Admin access: https://9c1a7e30f4bf28b00fe5a2f41125e31a-2-4-develop.instances.magento-community.engineering/admin_2149 Login: a4e85f47 Password: c75d46fee581

:white_check_mark: Confirmed by @krishprakash Thank you for verifying the issue. Based on the provided information internal tickets MC-40238 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

magento-engcom-team avatar Dec 25 '20 14:12 magento-engcom-team

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

stale[bot] avatar Apr 27 '21 22:04 stale[bot]

Hi @m2-assistant[bot], @DmitryFurs.

Thank you for your report and collaboration!

The related internal Jira ticket MC-40238 was closed as Fixed.

The fix will be available with the upcoming 2.4.3 release.

magento-engcom-team avatar May 12 '21 04:05 magento-engcom-team

Hi @DmitryFurs,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the attached video.

Manual testing scenarios

  • Create Cart Price Rule or Catalog Price Rule rule
  • Add Product attribute combination section
  • Сheck the category and attribute options

Screencast from 27-02-24 11:57:43 AM IST.webm

Some of them do not contain spaces, and some have a different style of writing words, some uppercase, and some uppercase letters.

Hence Confirming the issue.

Thanks.

engcom-Bravo avatar Feb 27 '24 06:02 engcom-Bravo

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11427 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Feb 27 '24 06:02 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Feb 27 '24 06:02 m2-assistant[bot]