Inconsistent labels for attributes in marketing rules

[DmitryFurs]

Description (*)

In task MAGETWO-94407, functionality was added for correct operation of marketing rules with configurable products. But additional labels for attributes are inconsistent. Some of them do not contain spaces, and some have a different style of writing words, some uppercase, and some uppercase letters.

Related Pull Requests

https://github.com/magento/magento2/commit/db41fab1f19a86dc90d2fc922e48a4707d240e15#diff-f4e77b2225e395e85ad967f315970b77f1557e94c2033038091750b2d4e11382

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. Create Cart Price Rule or Catalog Price Rule rule
2. Add Product attribute combination section
3. Сheck the category and attribute options

Questions or comments

Contribution checklist (*)

• [ ] Pull request has a meaningful description of its purpose
• [ ] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

1. [x] resolves magento/magento2#31232: Inconsistent labels for attributes in marketing rules

[m2-assistant[bot]]

Hi @DmitryFurs. Thank you for your contribution Here is some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[sidolov]

@magento create issue

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@magento run Functional Tests EE, Static Tests

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review. ENGCOM-8703 has been created to process this Pull Request

[DmitryFurs]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[DmitryFurs]

Hi @ihor-sviziev @sidolov! it looks like the linked issue https://github.com/magento/magento2/issues/31232 is closed, and the last comment says that the problem was fixed in 2.4.3, but the pull request was not merged, and this problem is still present in the code.

• https://github.com/magento/magento2/blame/2.4-develop/app/code/Magento/SalesRule/Model/Rule/Condition/Product.php#L29-L30
• https://github.com/magento/magento2/blame/2.4-develop/app/code/Magento/SalesRule/Model/Rule/Condition/Product.php#L78-L79

Maybe you need to re-open the issue? Thanks!

[engcom-Delta]

Hi @DmitryFurs , Thanks for your contribution.Please resolve the conflicts to move ahead on this PR

[DmitryFurs]

@engcom-Delta the conflict has been resolved.