magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Keep dependencies in composer.json sections sorted alphabetically

Open DmitryFurs opened this issue 5 years ago • 7 comments

Description (*)

Since we have the sort flag set to true, all sections must be sorted alphabetically.

Manual testing scenarios (*)

  1. open composer.json file
  2. check the replace section

Questions or comments

All package links sections should be sorted this way:

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

  1. [x] resolves magento/magento2#31182: Keep dependencies in composer.json sections sorted alphabetically

DmitryFurs avatar Dec 04 '20 18:12 DmitryFurs

Hi @DmitryFurs. Thank you for your contribution Here is some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Dec 04 '20 18:12 m2-assistant[bot]

@magento create issue

sidolov avatar Dec 04 '20 21:12 sidolov

@magento run all tests

DmitryFurs avatar Aug 02 '21 06:08 DmitryFurs

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Hello @DmitryFurs,

Please resolve the pr conflicts so we can move ahead with this.

engcom-November avatar May 09 '24 10:05 engcom-November

@magento run all tests

DmitryFurs avatar May 29 '24 10:05 DmitryFurs

@engcom-November the conflict has been resolved

DmitryFurs avatar May 29 '24 10:05 DmitryFurs