magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] module.xml file improvements for Magento_ConfigurableProductGraphQl, Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules.

Open m2-assistant[bot] opened this issue 4 years ago • 5 comments

This issue is automatically created based on existing pull request: magento/magento2#30638: module.xml file improvements for Magento_ConfigurableProductGraphQl, Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules.


Description (*)

Removed <module name=“Magento_Catalog”/> dependency from Magento_ConfigurableProductGraphQl, Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules. as those modules are already dependent on Magento_ConfigurableProduct, which is then dependent on Magento_Catalog. So need to add those dependencies.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar Oct 27 '20 19:10 m2-assistant[bot]

Confirming this issue

Screenshot 2024-01-03 at 11 20 15 AM Screenshot 2024-01-03 at 11 21 32 AM Screenshot 2024-01-03 at 11 22 14 AM Screenshot 2024-01-03 at 11 22 46 AM

engcom-Delta avatar Jan 03 '24 05:01 engcom-Delta

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot avatar Jan 03 '24 05:01 github-jira-sync-bot

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot avatar Jan 03 '24 05:01 github-jira-sync-bot

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-10762 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Jan 03 '24 05:01 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Jan 03 '24 05:01 m2-assistant[bot]