magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

module.xml file improvements for Magento_ConfigurableProductGraphQl, Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules.

Open sanganinamrata opened this issue 4 years ago • 9 comments

Description (*)

Removed <module name=“Magento_Catalog”/> dependency from Magento_ConfigurableProductGraphQl, Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules. as those modules are already dependent on Magento_ConfigurableProduct, which is then dependent on Magento_Catalog. So need to add those dependencies.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

  1. [x] resolves magento/magento2#30675: module.xml file improvements for Magento_ConfigurableProductGraphQl, Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules.

sanganinamrata avatar Oct 24 '20 09:10 sanganinamrata

Hi @sanganinamrata. Thank you for your contribution Here is some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Oct 24 '20 09:10 m2-assistant[bot]

@magento run all tests

rogyar avatar Oct 24 '20 10:10 rogyar

@magento create issue

sidolov avatar Oct 27 '20 19:10 sidolov

@magento run Functional Tests EE

rogyar avatar Oct 30 '20 16:10 rogyar

Hi @rogyar, thank you for the review. ENGCOM-8418 has been created to process this Pull Request

magento-engcom-team avatar Nov 03 '20 17:11 magento-engcom-team

Manual QA not applicable. Moved to Extended Testing column

engcom-Bravo avatar Nov 23 '20 13:11 engcom-Bravo

@magento run all tests

engcom-Delta avatar Dec 29 '23 12:12 engcom-Delta

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

:heavy_check_mark: QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

Go to the paths

  1. app/code/Magento/ConfigurableProductGraphQl/etc/module.xml
  2. app/code/Magento/MsrpConfigurableProduct/etc/module.xml
  3. app/code/Magento/NewRelicReporting/etc/module.xml
  4. app/code/Magento/Swatches/etc/module.xml
  5. Verify Removed dependency

Before: :heavy_multiplication_x: 

Screenshot 2024-01-03 at 11 20 15 AM Screenshot 2024-01-03 at 11 21 32 AM Screenshot 2024-01-03 at 11 22 14 AM Screenshot 2024-01-03 at 11 22 46 AM

After: :heavy_check_mark:  

Screenshot 2024-01-03 at 4 26 03 PM Screenshot 2024-01-03 at 4 26 43 PM Screenshot 2024-01-03 at 4 28 45 PM Screenshot 2024-01-03 at 4 29 15 PM

Builds are failed. Hence, moving this PR to Extended Testing.

engcom-Delta avatar Jan 03 '24 11:01 engcom-Delta